Failure to resolve - subtract with overflow

[mrginglymus]

My yarn.lock file contains the following entry:

./.yarn/__virtual__/@emotion-react-virtual-3d752878b5/3/Users/bill.collins/AppData/Local/Yarn/Berry/cache/@emotion-react-npm-11.14.0-2743f93910-10c0.zip/node_modules/@emotion/react/

the cwd is c:/dev/project

[JounQin]

@mrginglymus Does it work as expected now with unrs-resolver v1.11.0? There are some improvements and bugfixes on pnp-rs recently.

[mrginglymus]

@JounQin yes! Thanks for all the hard work on this.

[mrginglymus]

Oops, spoke to soon, sorry @JounQin. Was caught out editors not auto-saving. eslint still fails if the common folder between project and yarn cache is c:/

[JounQin]

@mrginglymus Could you please provide a reproduction with, for example, a failing test case on CI?

[mrginglymus]

It's tricky as getting the common folder to be root is unlikely to be doable on CI.

I'll see if I can get a failing test.

[mrginglymus]

Part of the problem is I'm not sure if this is a pnp-rs issue or unrs-resolver issue. Enabling logs for unrs-resolver, I get the following

1. with cache at c:\dev\.yarn, project at c:\dev\project

resolve {
path="C:\\dev\\project"
specifier="vitest/config"}:
...
path="C:\\dev\\project"
specifier="vitest/config"
ret="C:\\dev\\project\\.yarn\\__virtual__\\vitest-virtual-2dd0117f4d\\2\\.yarn\\berry\\cache\\vitest-npm-3.2.4-7a07f931b1-10c0.zip\\node_modules\\vitest\\dist\\config.js"

2. with cache at the default location (~\.AppData\Local\Yarn\Berry), project at c:\dev\project

resolve {
path="C:\\dev\\project"
specifier="vitest/config"}:
resolve {
path="C:/dev/project/.yarn/__virtual__/vitest-virtual-2dd0117f4d/3/Users/bill.collins/AppData/Local/Yarn/Berry/cache/vitest-npm-3.2.4-7a07f931b1-10c0.zip/node_modules/vitest/"
specifier="./config"}:
...
path="C:/dev/project/.yarn/__virtual__/vitest-virtual-2dd0117f4d/3/Users/bill.collins/AppData/Local/Yarn/Berry/cache/vitest-npm-3.2.4-7a07f931b1-10c0.zip/node_modules/vitest/"
specifier="./config"
err=NotFound("./config")

Of significance appears to be two calls to resolve, and a flipping from \ to /.

[JounQin]

So it seems related to global cache, but we do have a test case.

https://github.com/oxc-project/oxc-resolver/blob/9ec3337b01afde06a83d6c0b4f301c2cad6da51d/src/tests/pnp.rs#L183

Can you try to add a new one?

[mrginglymus]

I can't get those to pass on windows as is - aside from seemingly missing the windows-sys dependency, they are all failing with FailedToFindYarnPnpManifest.

I may be holding my rust wrong...

edit: am holding things wrong, need to run yarn in the fixture dir first

[mrginglymus]

However - the linked test is currently marked to skip on windows, and it fails when unskipped

[mrginglymus]

@JounQin here's a repro!

https://github.com/mrginglymus/unrs-resolver/tree/repro

It needs to be a package with peer dependencies to reproduce.

[mrginglymus]

These tests are sensitive to their environment, though - this will only reproduce the issue if you check out unrs-resolver in (e.g.) c:\dev\unrs-resolver. If it's checked out in ~\dev\unrs-reolver then it will pass.

[mrginglymus]

I've also got https://github.com/mrginglymus/pnp-rs/tree/via-root which adds a failing test that I think should pass.