Enhance ESLint config (#6357)

## What's the problem this PR addresses?

Follow up to #6276 and #6352. The ESLint config has room for improvement

- The include patterns are unnecessary wide and causes a lot more files
to be linted by default (See #6352, which is only a partial fix)
- The ignore patterns can be simplified
(#6276 (comment))
- There are some extraneous config files and config items
- The `@typescript-eslint/naming-convention` rule config in
`@yarnpkg/eslint-config` is shadowed by the one in `eslint.config.mjs`

## How did you fix it?

### Wide include

The culprit is this line 

https://github.com/yarnpkg/berry/blob/57ed709ceea1f45568f860729cc18ae324334289/eslint.config.mjs#L43

By only specifying a negated pattern, it matches **ALL** other files
that are not globally ignored. Under flat config, each file matched by
at least one config item (and is not globally ignored) is eligible for
linting. This causes the VSCode plugin to attempt to lint pretty much
every file.

The correct way to use both `files` and `ignores` to accurately specify
the set of files to be linted. With that, we can simplify the
`test:lint` command to just lint the whole repo and we have a single
source of truth of what should be linted. This also aligns with the
[default behavior of ESLint
v9](https://eslint.org/blog/2024/04/eslint-v9.0.0-released/#running-eslint-with-no-file-arguments)
for when we migrate. I have also taken the opportunity to widen the
typescript files globs to include `.cts` and `.mts` if we create those
in the future.

### Ignore patterns

See #6276 (comment).
Added a few missed ignores. Also grouped them by workspace.

### Extraneous configs

See #6276 (comment).
There are two sets of configs that specify jest globals for tests using
`env` but that is not supported in flat config and has already been
migrated in #6276.

### `@typescript-eslint/naming-convention`

The `@typescript-eslint/naming-convention` is configured twice, once in
`@yarnpkg/eslint-config` and once in `eslint.config.mjs`. But due to a
wide include glob in the latter, the former one is actually almost
entirely shadowed -- it only takes effect on `sources/index.ts` and
`sources/Plugin.ts` of each workspace.

There are already ~100 violations of the rule that went unreported due
to this shadowing. I have removed the shadowed config item since it
isn't really being enforced. (Or is that actually intentional?)

## Checklist

<!--- Don't worry if you miss something, chores are automatically
tested. -->
<!--- This checklist exists to help you remember doing the chores when
you submit a PR. -->
<!--- Put an `x` in all the boxes that apply. -->
- [x] I have read the [Contributing
Guide](https://yarnpkg.com/advanced/contributing).

<!-- See
https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released
for more details. -->
<!-- Check with `yarn version check` and fix with `yarn version check
-i` -->
- [x] I have set the packages that need to be released for my changes to
be effective.

<!-- The "Testing chores" workflow validates that your PR follows our
guidelines. -->
<!-- If it doesn't pass, click on it to see details as to what your PR
might be missing. -->
- [x] I will check that all automated PR checks pass before the PR gets
reviewed.

---------

Co-authored-by: Maël Nison <[email protected]>

Author: clemyan

.pnp.cjs

@@ -0,0 +1,2 @@
+releases:
+  "@yarnpkg/eslint-config": minor

.yarn/cache/@esbuild-darwin-arm64-npm-0.21.5-62349c1520-10.zip

@@ -3,44 +3,61 @@ import eslintConfig      from '@yarnpkg/eslint-config';
 
 // eslint-disable-next-line arca/no-default-export
 export default [
-  ...eslintConfig,
-  ...reactEslintConfig,
-
   {
     ignores: [
-      `*.json`,
       `**/coverage/**`,
+      `**/__snapshots__/**`,
       `.yarn`,
+      `.pnp.cjs`,
+      `.pnp.loader.mjs`,
 
-      `packages/docusaurus/.docusaurus`,
-
-      `packages/yarnpkg-pnp/sources/hook.js`,
-      `packages/yarnpkg-pnp/sources/esm-loader/built-loader.js`,
+      // Pre-compiled binaries
+      `packages/*/lib`,
+      `packages/*/bin`,
+      `packages/*/build`,
+      `packages/*/bundles`,
 
-      `packages/yarnpkg-libzip/sources/libzipAsync.js`,
-      `packages/yarnpkg-libzip/sources/libzipSync.js`,
+      // Test fixtures
+      `packages/**/*fixtures*`,
 
-      // The parsers are auto-generated
-      `packages/yarnpkg-parsers/sources/grammars/*.js`,
+      // Generated files for website
+      `packages/docusaurus/.docusaurus`,
 
+      // Generated compressed worker
       `packages/yarnpkg-core/sources/worker-zip/index.js`,
-      `packages/yarnpkg-cli/bundles/yarn.js`,
 
-      `packages/*/lib`,
-      `packages/*/bin`,
-      `packages/*/build`,
-      `packages/**/*fixtures*`,
+      // Build output for libui
+      `packages/yarnpkg-libui/sources/**/*.js`,
+      `packages/yarnpkg-libui/sources/**/*.d.ts`,
+
+      // Pre-compiled from C sources
+      `packages/yarnpkg-libzip/sources/libzipAsync.js`,
+      `packages/yarnpkg-libzip/sources/libzipSync.js`,
+      // The C sources themselves
       `packages/yarnpkg-libzip/artifacts`,
-      `packages/plugin-compat/extra/fsevents/fsevents-*.js`,
 
-      // Minimize the diff with upstream`,
+      // Generated compressed hooks
+      `packages/yarnpkg-pnp/sources/hook.js`,
+      `packages/yarnpkg-pnp/sources/esm-loader/built-loader.js`,
+      // Minimize the diff with upstream
       `packages/yarnpkg-pnp/sources/node`,
       `packages/yarnpkg-pnp/sources/loader/node-options*`,
+
+      // Generated PEG.js grammars
+      `packages/yarnpkg-parsers/sources/grammars/*.js`,
+
+      // Patched fsevents
+      `packages/plugin-compat/extra/fsevents/fsevents-*.js`,
     ],
   },
 
+  ...eslintConfig,
+  ...reactEslintConfig,
+
   {
-    files: [`!packages/*/sources/{index,Plugin}.ts`],
+    name: `berry/naming-convention`,
+    files: [`**/*.ts`, `**/*.cts`, `**/*.mts`, `**/*.tsx`],
+    ignores: [`packages/*/sources/{index,Plugin}.ts`],
     rules: {
       '@typescript-eslint/naming-convention': [`error`, {
         selector: `typeLike`,
@@ -54,6 +71,7 @@ export default [
   },
 
   {
+    name: `berry/env/acceptance-tests`,
     files: [`packages/acceptance-tests/pkg-tests-specs/**/*.test.{js,ts}`],
     languageOptions: {
       globals: {
@@ -64,6 +82,7 @@ export default [
   },
 
   {
+    name: `berry/rules`,
     rules: {
       'no-restricted-properties': [2,
         {

.yarn/cache/@esbuild-darwin-x64-npm-0.21.5-491c2ae06c-10.zip

@@ -7,6 +7,7 @@
   ],
   "devDependencies": {
     "@arcanis/sherlock": "^2.0.3",
+    "@eslint/config-inspector": "^0.5.0",
     "@types/jest": "^28.1.6",
     "@types/micromatch": "^4.0.1",
     "@types/node": "^18.17.15",
@@ -54,7 +55,7 @@
     "build:plugin-workspace-tools": "yarn node -r ./scripts/setup-ts-execution ./scripts/create-mock-plugin.ts workspace-tools",
     "build:plugin-commands": "node ./scripts/gen-plugin-commands.js > packages/yarnpkg-cli/sources/pluginCommands.ts",
     "build:compile": "rm -rf \"$0\"/lib && mkdir -p \"$0\"/lib && rsync -a --include '*.d.ts' --exclude '*.ts' --exclude '*.tsx' \"$0\"/sources/ \"$0\"/lib/ && node scripts/compile \"$@\"",
-    "test:lint": "eslint --max-warnings 0 \"./**/*.@(tsx|ts|js|mjs)\"",
+    "test:lint": "eslint --max-warnings 0 .",
     "test:unit": "jest",
     "typecheck:all": "tsc -p ."
   },

.yarn/cache/@esbuild-linux-arm64-npm-0.21.5-c6a54cd648-10.zip

@@ -8,28 +8,35 @@ import typescript    from './rules/typescript.js';
 
 // eslint-disable-next-line arca/no-default-export
 export default [
-  ...bestPractices,
-  ...errors,
-  ...style,
-  ...typescript,
-
   {
+    name: `@yarnpkg/setup`,
     languageOptions: {
       parser: tsParser,
       sourceType: `module`,
+    },
+  },
+  {
+    name: `@yarnpkg/env`,
+    languageOptions: {
       globals: {
         ...globals.node,
         ...globals.es2021,
       },
     },
   },
-
   {
+    name: `@yarnpkg/env/tests`,
     files: [`**/*.test.*`],
+    ignores: [`**/__snapshots__/**`],
     languageOptions: {
       globals: {
         ...globals.jest,
       },
     },
   },
+
+  ...bestPractices,
+  ...errors,
+  ...style,
+  ...typescript,
 ];

.yarn/cache/@esbuild-linux-x64-npm-0.21.5-88079726c4-10.zip

@@ -4,6 +4,8 @@ import arcaEslint       from 'eslint-plugin-arca';
 // eslint-disable-next-line arca/no-default-export
 export default [
   {
+    name: `@yarnpkg/configs/best-practices`,
+
     plugins: {
       [`arca`]: arcaEslint,
       [`@typescript-eslint`]: typescriptEslint,

.yarn/cache/@esbuild-win32-arm64-npm-0.21.5-d0ef444aab-10.zip

@@ -4,6 +4,8 @@ import arcaEslint       from 'eslint-plugin-arca';
 // eslint-disable-next-line arca/no-default-export
 export default [
   {
+    name: `@yarnpkg/configs/errors`,
+
     plugins: {
       [`arca`]: arcaEslint,
       [`@typescript-eslint`]: typescriptEslint,
@@ -73,10 +75,4 @@ export default [
       'valid-typeof': 2,
     },
   },
-  {
-    files: [`*.test.{js,ts}`],
-    env: {
-      jest: true,
-    },
-  },
 ];

.yarn/cache/@esbuild-win32-x64-npm-0.21.5-eddc2b5ad6-10.zip

@@ -4,6 +4,8 @@ import reactEslint from 'eslint-plugin-react';
 // eslint-disable-next-line arca/no-default-export
 export default [
   {
+    name: `@yarnpkg/configs/react`,
+
     plugins: {
       [`arca`]: arcaEslint,
       [`react`]: reactEslint,

.yarn/cache/@eslint-config-array-npm-0.16.0-3d9e707ee8-6c1716f896.zip

@@ -4,6 +4,8 @@ import arcaEslint       from 'eslint-plugin-arca';
 // eslint-disable-next-line arca/no-default-export
 export default [
   {
+    name: `@yarnpkg/configs/style`,
+
     plugins: {
       [`arca`]: arcaEslint,
       [`@typescript-eslint`]: typescriptEslint,
@@ -22,16 +24,6 @@ export default [
 
       '@typescript-eslint/comma-spacing': 2,
 
-      '@typescript-eslint/naming-convention': [`error`, {
-        selector: `default`,
-        format: [`camelCase`, `UPPER_CASE`, `PascalCase`],
-        filter: {
-          regex: `^(__.*|__non_webpack_require__|npm(_[a-z]+)+)$`,
-          match: false,
-        },
-        leadingUnderscore: `allow`,
-      }],
-
       '@typescript-eslint/func-call-spacing': 2,
 
       '@typescript-eslint/indent': [`error`, 2, {

.yarn/cache/@eslint-config-inspector-npm-0.5.0-055b680b5e-37d1d779d7.zip

@@ -3,7 +3,9 @@ import typescriptEslint from '@typescript-eslint/eslint-plugin';
 // eslint-disable-next-line arca/no-default-export
 export default [
   {
-    files: [`**/*.{ts,tsx}`],
+    name: `@yarnpkg/configs/typescript`,
+
+    files: [`**/*.ts`, `**/*.cts`, `**/*.mts`, `**/*.tsx`],
 
     plugins: {
       [`@typescript-eslint`]: typescriptEslint,