Skip to content

Commit 2243ce9

Browse files
clemyanmerceyz
andauthored
Fix (partially) Svelte E2E test (#6428)
## What's the problem this PR addresses? The SvelteKit E2E test has been failing ## How did you fix it? - `create-svelte` discontinued the `next` dist-tag, use `latest` instead - I don't know how it was but `yes` cannot defeat `create-svelte` interactivity now, so I just use its node API instead - Also added a TypeScript test The test should still be failing due to sveltejs/kit#11433 (comment), but at least it is an actual failure of the E2E test, not of our setup. :shrug: Closes #6345 ## Checklist <!--- Don't worry if you miss something, chores are automatically tested. --> <!--- This checklist exists to help you remember doing the chores when you submit a PR. --> <!--- Put an `x` in all the boxes that apply. --> - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). <!-- See https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released for more details. --> <!-- Check with `yarn version check` and fix with `yarn version check -i` --> - [x] I have set the packages that need to be released for my changes to be effective. <!-- The "Testing chores" workflow validates that your PR follows our guidelines. --> <!-- If it doesn't pass, click on it to see details as to what your PR might be missing. --> - [x] I will check that all automated PR checks pass before the PR gets reviewed. --------- Co-authored-by: Kristoffer K. <[email protected]>
1 parent d85532f commit 2243ce9

File tree

1 file changed

+24
-1
lines changed

1 file changed

+24
-1
lines changed

.github/workflows/e2e-svelte-kit-workflow.yml

Lines changed: 24 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,29 @@ jobs:
2424
- name: 'Running the integration test'
2525
run: |
2626
source scripts/e2e-setup-ci.sh
27-
yes | yarn create svelte@next my-app && cd my-app
27+
28+
yarn init -p
29+
yarn add -D create-svelte@latest
30+
31+
yarn node -e "import('create-svelte').then(({create}) => create('my-app', {name:'my-app', template:'default', types:null}))"
32+
cd my-app
33+
touch yarn.lock
34+
35+
yarn
36+
yarn build
37+
38+
- name: 'Running the TypeScript integration test'
39+
run: |
40+
source scripts/e2e-setup-ci.sh
41+
42+
yarn init -p
43+
yarn add -D create-svelte@latest
44+
45+
yarn node -e "import('create-svelte').then(({create}) => create('my-app', {name:'my-app', template:'default', types:'typescript'}))"
46+
cd my-app
47+
touch yarn.lock
48+
2849
yarn
2950
yarn build
51+
if: |
52+
success() || failure()

0 commit comments

Comments
 (0)