Modals shifted to top-left due to `transform: translate` after upgrade

[alexmiddeleer]

I just upgraded from a very old version of this addon, and it seems I now need to use targetAttachment="none" to avoid my modals being pushed off to the side (including new ones such as {{#modal-dialog}} hello world {{/modal-dialog}}). If this is normal for apps not using tether, I can submit a PR updating the README; otherwise, any idea why my setup is defaulting the the css class which applies a transform: translate(-50%, -50%)?

[williamhector]

We're in a similar situation. Is there a reason for the redundant translate -50% rule that we need to be aware of, or is it just a mistake?
@alexmiddeleer I disabled it for now by setting the css rule:
.ember-modal-wrapper.emd-static.emd-wrapper-target-attachment-center .ember-modal-dialog { transform: none; }
so I can keep the real intended alignment settings, and so that when a fix is released, there's no rush to undo the workaround.

[Redsandro]

I have the same issue.

Somehow, the attachment is positioned fine in the center, but the addon then applies a negative margin-top and margin-left with values half the height and width of the dialog.

When you disable these, the modal is moved to the center.

@williamhector's suggestion also works. I've implemented it like so:

@import "ember-modal-dialog/ember-modal-structure";
@import "ember-modal-dialog/ember-modal-appearance";

// Workaround for positioning issue
// https://github.com/yapplabs/ember-modal-dialog/issues/213
.ember-modal-dialog-target-attachment-center {
	transform: none !important;
}