Removed {{action}} helper from addon (#411)

ijlee2 · web-flow · commit f0d7ba854a97 · 2024-12-06T06:42:27.000+01:00
* chore: Removed {{action}} helper from addon

* chore: Removed {{action}} helper from docs-app

---------

Co-authored-by: ijlee2 &lt;ijlee2@users.noreply.github.com&gt;
diff --git a/addon/components/basic-dialog.hbs b/addon/components/basic-dialog.hbs
@@ -27,8 +27,8 @@
       {{#if this.hasOverlay}}
         <EmberModalDialog::Overlay
           class={{this.overlayClassNamesString}}
-          @onClickOverlay={{action
-            (ignore-children this.onClickOverlay)
+          @onClickOverlay={{ignore-children
+            this.onClickOverlay
           }}
         >
           <EmberModalDialogPositionedContainer
diff --git a/addon/components/liquid-dialog.hbs b/addon/components/liquid-dialog.hbs
@@ -41,9 +41,7 @@
     {{#if this.hasOverlay}}
       <EmberModalDialog::Overlay
         class={{this.overlayClassNamesString}}
-        @onClickOverlay={{action
-          (ignore-children this.onClickOverlay)
-        }}
+        @onClickOverlay={{ignore-children this.onClickOverlay}}
       >
         <div
           class={{this.containerClassNamesString}}
diff --git a/tests/dummy/app/utils/code-snippets/index.js b/tests/dummy/app/utils/code-snippets/index.js
@@ -160,7 +160,7 @@ export default class MyCoolModalDialog extends ModalDialogComponent {
 }`,
 
   'subclass-modal-dialog-animatable-hbs': `<MyCoolModalDialog
-  @onClose={{action "toggleSubclassed"}}
+  @onClose={{this.closeModal}}
   @animatable={{true}}
 >
   <h1>Stop! Modal Time!</h1>

Original file line number	Diff line number	Diff line change
`@@ -160,7 +160,7 @@ export default class MyCoolModalDialog extends ModalDialogComponent {`
`160`	`160`	}`,
`161`	`161`
`162`	`162`	'subclass-modal-dialog-animatable-hbs': `<MyCoolModalDialog
`163`		`- @onClose={{action "toggleSubclassed"}}`
	`163`	`+ @onClose={{this.closeModal}}`
`164`	`164`	`@animatable={{true}}`
`165`	`165`	`>`
`166`	`166`	`<h1>Stop! Modal Time!</h1>`