Skip to content

Commit 439a062

Browse files
RobbieTheWagnerRobbieTheWagner
authored
Update liquid-* deps, remove @ember/string usage (#415)
* Update liquid-* deps, remove @ember/string usage * Update package.json * pnpm update * Update liquid-tether * Update -liquid-dialog-test.js * Update -liquid-dialog-test.js * Use actual liquid-tether release
1 parent d919ebf commit 439a062

File tree

9 files changed

+3495
-3474
lines changed

9 files changed

+3495
-3474
lines changed

‎addon/components/basic-dialog.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { computed, set } from '@ember/object';
22
import { inject as service } from '@ember/service';
33
import Component from '@ember/component';
44
import { isEmpty } from '@ember/utils';
5-
import { dasherize } from '@ember/string';
5+
import { dasherize } from '../utils/string-utils';
66

77
import { isIOS, clickHandlerDelay } from '../utils/config-utils';
88

‎addon/components/liquid-tether-dialog.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/* eslint-disable ember/no-computed-properties-in-native-classes */
22
import { computed, set } from '@ember/object';
3-
import { dasherize } from '@ember/string';
3+
import { dasherize } from '../utils/string-utils';
44

55
import BasicDialog from './basic-dialog';
66

‎addon/components/modal-dialog.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import Component from '@glimmer/component';
22
import { inject as service } from '@ember/service';
3-
import { dasherize } from '@ember/string';
3+
import { dasherize } from '../utils/string-utils';
44
import { typeOf } from '@ember/utils';
55
import { assert, warn } from '@ember/debug';
66
import { DEBUG } from '@glimmer/env';

‎addon/components/positioned-container.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { assert } from '@ember/debug';
22
import { typeOf } from '@ember/utils';
33
import Component from '@ember/component';
4-
import { capitalize } from '@ember/string';
4+
import { capitalize } from '../utils/string-utils';
55
import { observer, computed } from '@ember/object';
66
import { on } from '@ember/object/evented';
77

‎addon/components/tether-dialog.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { computed, set } from '@ember/object';
2-
import { dasherize } from '@ember/string';
2+
import { dasherize } from '../utils/string-utils';
33

44
import BasicDialog from './basic-dialog';
55

‎addon/utils/string-utils.js‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
/**
2+
* Converts a camelCase or other string to kebab-case (dasherized)
3+
* @param {string} str - The string to dasherize
4+
* @returns {string} The dasherized string
5+
*/
6+
export function dasherize(str) {
7+
return str
8+
.replace(/([a-z\d])([A-Z])/g, '$1-$2')
9+
.replace(/([A-Z]+)([A-Z][a-z\d]+)/g, '$1-$2')
10+
.toLowerCase();
11+
}
12+
13+
/**
14+
* Capitalizes the first letter of a string
15+
* @param {string} str - The string to capitalize
16+
* @returns {string} The capitalized string
17+
*/
18+
export function capitalize(str) {
19+
return str.charAt(0).toUpperCase() + str.slice(1);
20+
}

‎package.json‎

Lines changed: 39 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -28,66 +28,67 @@
2828
"test:ember-compatibility": "ember try:one"
2929
},
3030
"dependencies": {
31-
"@babel/core": "^7.26.0",
32-
"@embroider/macros": "^1.16.9",
33-
"@embroider/util": "^1.13.2",
31+
"@babel/core": "^7.28.5",
32+
"@embroider/macros": "^1.19.5",
33+
"@embroider/util": "^1.13.5",
3434
"ember-cli-babel": "^8.2.0",
3535
"ember-cli-htmlbars": "^6.3.0",
3636
"ember-cli-version-checker": "^5.1.2",
37-
"ember-wormhole": "^0.6.0"
37+
"ember-wormhole": "^0.6.1"
3838
},
3939
"devDependencies": {
40-
"@babel/eslint-parser": "^7.25.9",
41-
"@babel/plugin-proposal-decorators": "^7.25.9",
42-
"@ember/optional-features": "^2.1.0",
43-
"@ember/string": "^3.0.0",
44-
"@ember/test-helpers": "^4.0.4",
40+
"@babel/eslint-parser": "^7.28.5",
41+
"@babel/plugin-proposal-decorators": "^7.28.0",
42+
"@ember/optional-features": "^2.3.0",
43+
"@ember/test-helpers": "^4.0.5",
4544
"@embroider/test-setup": "^4.0.0",
4645
"@glimmer/component": "^1.1.2",
4746
"@glimmer/tracking": "^1.1.2",
4847
"broccoli-asset-rev": "^3.0.0",
49-
"concurrently": "^9.1.0",
50-
"ember-auto-import": "^2.10.0",
48+
"concurrently": "^9.2.1",
49+
"ember-auto-import": "^2.12.0",
5150
"ember-cli": "~5.12.0",
52-
"ember-cli-dependency-checker": "^3.3.2",
53-
"ember-cli-deprecation-workflow": "^3.0.2",
51+
"ember-cli-dependency-checker": "^3.3.3",
52+
"ember-cli-deprecation-workflow": "^3.4.0",
5453
"ember-cli-github-pages": "^0.2.2",
5554
"ember-cli-inject-live-reload": "^2.1.0",
5655
"ember-cli-terser": "^4.0.2",
5756
"ember-disable-prototype-extensions": "^1.1.3",
5857
"ember-load-initializers": "^2.1.2",
5958
"ember-qunit": "^8.1.1",
60-
"ember-resolver": "^13.1.0",
59+
"ember-resolver": "^13.1.1",
6160
"ember-shiki": "^0.3.0",
6261
"ember-source": "~5.12.0",
6362
"ember-source-channel-url": "^3.0.0",
64-
"ember-template-lint": "^6.0.0",
63+
"ember-template-lint": "^6.1.0",
6564
"ember-template-lint-plugin-prettier": "^5.0.0",
66-
"ember-tether": "^3.1.0",
65+
"ember-tether": "^3.1.1",
6766
"ember-try": "^3.0.0",
6867
"eslint": "^8.57.1",
69-
"eslint-config-prettier": "^9.1.0",
70-
"eslint-plugin-ember": "^12.3.3",
71-
"eslint-plugin-n": "^17.14.0",
72-
"eslint-plugin-prettier": "^5.2.1",
73-
"eslint-plugin-qunit": "^8.1.2",
74-
"liquid-fire": "0.34.0",
75-
"liquid-tether": "pzuraq/liquid-tether#7c140024787c3c1b266e89a2ef528eaea898c78e",
76-
"liquid-wormhole": "pzuraq/liquid-wormhole#efa7e5ca518de7c1d6c52666b70bbc0671fcf380",
68+
"eslint-config-prettier": "^9.1.2",
69+
"eslint-plugin-ember": "^12.7.5",
70+
"eslint-plugin-n": "^17.23.1",
71+
"eslint-plugin-prettier": "^5.5.4",
72+
"eslint-plugin-qunit": "^8.2.5",
73+
"liquid-fire": "^0.37.1",
74+
"liquid-tether": "^3.0.0",
75+
"liquid-wormhole": "^6.0.0",
7776
"loader.js": "^4.7.0",
78-
"only-allow": "^1.2.1",
79-
"prettier": "^3.3.3",
80-
"qunit": "^2.22.0",
81-
"qunit-dom": "^3.3.0",
77+
"only-allow": "^1.2.2",
78+
"prettier": "^3.7.4",
79+
"qunit": "^2.24.3",
80+
"qunit-dom": "^3.5.0",
8281
"release-it": "^13.7.2",
8382
"release-it-lerna-changelog": "^2.4.0",
84-
"webpack": "^5.96.1"
83+
"velocity-animate": "^1.5.2",
84+
"webpack": "^5.103.0"
8585
},
8686
"peerDependencies": {
87-
"@ember/string": "^3.0.0 || ^4.0.0",
8887
"ember-tether": "^3.0.0",
89-
"liquid-tether": "^2.0.7",
90-
"liquid-wormhole": "^3.0.1"
88+
"liquid-fire": "^0.37.1",
89+
"liquid-tether": "^3.0.0",
90+
"liquid-wormhole": "^6.0.0",
91+
"velocity-animate": "^1.5.2"
9192
},
9293
"peerDependenciesMeta": {
9394
"ember-tether": {
@@ -112,8 +113,11 @@
112113
"ember-addon": {
113114
"configPath": "tests/dummy/config",
114115
"demoURL": "http://yapplabs.github.io/ember-modal-dialog/",
116+
"after": [
117+
"liquid-fire"
118+
],
115119
"versionCompatibility": {
116-
"ember": "~3.20.0 || ~3.24.0 || >= 3.25.0"
120+
"ember": ">= 3.28.0"
117121
}
118122
},
119123
"release-it": {
@@ -132,8 +136,8 @@
132136
}
133137
},
134138
"volta": {
135-
"node": "20.14.0",
136-
"pnpm": "9.14.2"
139+
"node": "20.19.6",
140+
"pnpm": "10.24.0"
137141
},
138142
"pnpm": {
139143
"overrides": {

0 commit comments

Comments
 (0)