Skip to content

Enum values missing in Dependabot/Code Scanning Alert schema #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
maxstaas1910 opened this issue Apr 10, 2025 · 3 comments · Fixed by #204
Closed

Enum values missing in Dependabot/Code Scanning Alert schema #205

maxstaas1910 opened this issue Apr 10, 2025 · 3 comments · Fixed by #204
Labels
bug Something isn't working Rest API schema schema related

Comments

@maxstaas1910
Copy link
Contributor

Hi,
there is two values missing from the schema that cause validation errors:

  • The Dependabot Alert with Repository dependency prop relation can be "inconclusive"
  • The Code Scanning Alert classification can be "documentation"

I have addressed the issue in a PR.
Thank you very much for the project, it is very helpful :)
@maxstaas1910 maxstaas1910 mentioned this issue Apr 10, 2025
Merged
@yanyongyu yanyongyu added bug Something isn't working schema schema related Rest API labels Apr 10, 2025
@yanyongyu
Copy link
Owner

Could you please provide a link to the affected APIs because i'm not familiar with dependabot, code scanning alerts?

Also, you can report the schema error to the upstream repo https://github.com/github/rest-api-description at the same time.

@BenedictStrunk-otto
Copy link

Links to the APIs:

Issues in rest-api-description:
github/rest-api-description#4727
github/rest-api-description#4728

@yanyongyu yanyongyu changed the title Two Values missing in schema arrays. Enum values missing in Dependabot/Code Scanning Alert schema Apr 11, 2025
@yanyongyu yanyongyu linked a pull request Apr 11, 2025 that will close this issue
Fix: add missing enum values for dependabot and code scanning alerts #204
Merged
@yanyongyu
Copy link
Owner

Thx! This will be addressed in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Rest API schema schema related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: add missing enum values for dependabot and code scanning alerts maxstaas1910/githubkit
3 participants
@yanyongyu @maxstaas1910 @BenedictStrunk-otto