Add quotes for fields containing spaces in CmdSerializer

Author: yannh

redisdump/redisdump.go

@@ -66,7 +66,22 @@ func RESPSerializer(cmd []string) string {
 
 // RedisCmdSerializer will serialize cmd to a string with redis commands
 func RedisCmdSerializer(cmd []string) string {
-	return strings.Join(cmd, " ")
+	if len(cmd) == 0 {
+		return ""
+	}
+	res := ""
+	for i, s := range cmd {
+		if i>0 {
+			res += " "
+		}
+		if strings.Contains(s, " ") {
+			res += "\"" + s + "\""
+		} else {
+			res += s
+		}
+	}
+
+	return res
 }
 
 func dumpKeys(client radix.Client, keys []string, withTTL bool, logger *log.Logger, serializer func([]string) string) error {

redisdump/redisdump_test.go

@@ -73,7 +73,7 @@ func TestHashToRedisCmd(t *testing.T) {
 	}
 
 	testCases := []testCase{
-		{key: "Paris", value: map[string]string{"country": "France", "weather": "sunny"}, expected: []string{"HSET", "Paris", "country", "France", "weather", "sunny"}},
+		{key: "Paris", value: map[string]string{"country": "France", "weather": "sunny", "poi": "Tour Eiffel"}, expected: []string{"HSET", "Paris", "country", "France", "weather", "sunny", "poi", "Tour Eiffel"}},
 	}
 
 	for _, test := range testCases {
@@ -125,6 +125,26 @@ func TestRESPSerializer(t *testing.T) {
 	}
 }
 
+
+func TestRedisCmdSerializer(t *testing.T) {
+	type testCase struct {
+		command  []string
+		expected string
+	}
+
+	testCases := []testCase{
+		{command: []string{"SET", "key name 1", "key value 1"}, expected: "SET \"key name 1\" \"key value 1\""},
+		{command: []string{"HSET", "key1", "key value 1"}, expected: "HSET key1 \"key value 1\""},
+	}
+
+	for _, test := range testCases {
+		s := RedisCmdSerializer(test.command)
+		if s != test.expected {
+			t.Errorf("Failed serializing command to redis protocol: expected %s, got %s", test.expected, s)
+		}
+	}
+}
+
 func TestParseKeyspaceInfo(t *testing.T) {
 	keyspaceInfo := `# Keyspace
 	db0:keys=2,expires=1,avg_ttl=1009946407050