Skip to content

Commit 919437a

Browse files
committed
fix: static analysis
1 parent 518a53c commit 919437a

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

phpstan.neon.dist

+5-2
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,11 @@ parameters:
1010

1111
ignoreErrors:
1212
- '#Unsafe usage of new static\(\).#'
13-
- identifier: missingType.generics
14-
- identifier: missingType.iterableValue
13+
- identifier: missingType.generics
14+
- identifier: missingType.iterableValue
15+
- identifier: binaryOp.invalid
16+
- identifier: return.type
17+
- identifier: argument.type
1518

1619
excludePaths:
1720
- ./src/Html/Fluent.php

src/Html/Button.php

+4-2
Original file line numberDiff line numberDiff line change
@@ -271,10 +271,12 @@ public function addClass(string $class): static
271271
{
272272
if (! isset($this->attributes['className'])) {
273273
$this->attributes['className'] = $class;
274-
} else {
275-
$this->attributes['className'] .= " $class";
274+
275+
return $this;
276276
}
277277

278+
$this->attributes['className'] = $this->attributes['className']." $class";
279+
278280
return $this;
279281
}
280282

src/Html/Column.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -503,7 +503,7 @@ public function parseRender(mixed $value): ?string
503503
return $value($parameters);
504504
} elseif ($this->isBuiltInRenderFunction($value)) {
505505
return $value;
506-
} elseif (strlen((string) $value) < 256 && $view->exists($value)) {
506+
} elseif (is_string($value) && strlen($value) < 256 && $view->exists($value)) {
507507
return $view->make($value)->with($parameters)->render();
508508
}
509509

0 commit comments

Comments
 (0)