Skip to content

Fix setFilter RPC response similar to loadFile #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
coderabbitai bot opened this issue May 15, 2025 · 1 comment
Open

Fix setFilter RPC response similar to loadFile #277

coderabbitai bot opened this issue May 15, 2025 · 1 comment

Comments

@coderabbitai
Copy link

coderabbitai bot commented May 15, 2025

Description

The RPC mechanism has been refactored in PR #224, which fixed the LOAD_FILE response. However, the SET_FILTER functionality was not addressed in the same PR.

Expected behavior

The setFilter RPC should return appropriate response data, similar to how loadFile was fixed.

Related Issues

@hoophalab
Copy link
Contributor

We should remove LogFileManagerProxy and let the renderer functions call LogFileManager directly, given that RPC provides us with a great flexibility of communicating between workers.

@junhaoliao junhaoliao removed their assignment May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants