Skip to content

Bug: MenuBar CSS uses incorrect height variable #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
coderabbitai bot opened this issue Apr 21, 2025 · 1 comment
Closed

Bug: MenuBar CSS uses incorrect height variable #253

coderabbitai bot opened this issue Apr 21, 2025 · 1 comment
Assignees

Comments

@coderabbitai
Copy link

coderabbitai bot commented Apr 21, 2025

Description

The MenuBar component's CSS is using the incorrect CSS variable for heights:

  1. In .menu-bar class, it's using --ylv-status-bar-height but should be using --ylv-menu-bar-height
  2. In .menu-bar-logo-container class, it's using --ylv-status-bar-height but should be using --ylv-menu-bar-height

Although both variables currently have the same value (32px), for semantic correctness and future maintainability, the proper variables should be used.

Suggested Fix

In new-log-viewer/src/components/MenuBar/index.css:

 .menu-bar {
     z-index: var(--ylv-menu-bar-z-index);

     display: flex;
     flex-direction: row;
     align-items: center;

-    height: var(--ylv-status-bar-height);
+    height: var(--ylv-menu-bar-height);

     /* stylelint-disable-next-line custom-property-pattern */
     box-shadow: 0 1px 0 0 var(--joy-palette-neutral-outlinedBorder);
 }

 .menu-bar-logo-container {
     display: flex;
     justify-content: center;
     width: 48px;
-    height: var(--ylv-status-bar-height);
+    height: var(--ylv-menu-bar-height);

Issue identified in PR #74 by @junhaoliao

@junhaoliao
Copy link
Member

Fixed by #254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant