You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The MenuBar component's CSS is using the incorrect CSS variable for heights:
In .menu-bar class, it's using --ylv-status-bar-height but should be using --ylv-menu-bar-height
In .menu-bar-logo-container class, it's using --ylv-status-bar-height but should be using --ylv-menu-bar-height
Although both variables currently have the same value (32px), for semantic correctness and future maintainability, the proper variables should be used.
Suggested Fix
In new-log-viewer/src/components/MenuBar/index.css:
Description
The MenuBar component's CSS is using the incorrect CSS variable for heights:
.menu-bar
class, it's using--ylv-status-bar-height
but should be using--ylv-menu-bar-height
.menu-bar-logo-container
class, it's using--ylv-status-bar-height
but should be using--ylv-menu-bar-height
Although both variables currently have the same value (32px), for semantic correctness and future maintainability, the proper variables should be used.
Suggested Fix
In
new-log-viewer/src/components/MenuBar/index.css
:Issue identified in PR #74 by @junhaoliao
The text was updated successfully, but these errors were encountered: