Skip to content

js-beautify should be listed in dependencies while @types/js-beautify should be listed in devDependencies. #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
junhaoliao opened this issue Apr 12, 2025 · 0 comments · Fixed by #232
Labels
bug Something isn't working

Comments

@junhaoliao
Copy link
Member

Bug

It's my mistake missing this in the review of #223 .

In a project, dependencies are packages required at runtime, while devDependencies are only needed during development. Therefore, js-beautify should be in dependencies since it's used in the app, and @types/js-beautify should be in devDependencies as it's only used for type checking during development.

yscope-log-viewer version

eb3769a

Environment

unrelated - code issue

Reproduction steps

see https://github.com/y-scope/yscope-log-viewer/blob/eb3769a6f343fd000740651c9616d4360aff4fa2/package.json

@junhaoliao junhaoliao added the bug Something isn't working label Apr 12, 2025
junhaoliao added a commit to junhaoliao/yscope-log-viewer that referenced this issue Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant