-
Notifications
You must be signed in to change notification settings - Fork 18
Cache last opened file in log-viewer for persistence #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @junhaoliao , I find that this function in So I think we can just modify this function to check if it starts with |
We probably should only cache local file and leave remote file as-is or cache it with some expiration time, i.e. couple minutes. What do you think @junhaoliao |
cc @zzxthehappiest @jackluo923 I believe the approach proposed by @zzxthehappiest could work; however, the HTTP utilities are used to handle HTTP requests only, so I'd probably avoid making the modification at the If I'm not mistaken, the concern raised by @jackluo923 relates to data retention and security compliance.
Let me know your thoughts on these |
@junhaoliao I encountered pain when adjusting LLM and other configs when working with local file. Whenever I adjust some configs, the log-viewer would reload, and I would need to drag and drop the local file back into the log-viewer again. This is the main issue that I wish it can be resolved. For remote logs, the above behavior seems to be a non-issue. |
@jackluo923 I can look into this after I finished my current PRs. |
Background
Currently, the log-viewer doesn't cache the last opened file, so whenever a user refreshes the browser page, the last opened file is lost. This makes sharing links to local files impractical (e.g.,
http://localhost:3010/#logEventNum=12
) as they are not accessible across sessions.Feature Request
Implement functionality to cache and restore the last opened file when the log-viewer is refreshed or reopened.
Proposed Implementation
Utilize modern web standards to store file references persistently:
These APIs would allow storing the file reference and related viewing state (such as scroll position, filters, etc.) across browser sessions.
Related Discussion
This request originated from a discussion in #220.
cc @junhaoliao
The text was updated successfully, but these errors were encountered: