Skip to content

fix: Handle cursor change events with NotSet reason in setupCursorExplicitPosChangeCallback #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
coderabbitai bot opened this issue Feb 14, 2025 · 1 comment
Assignees

Comments

@coderabbitai
Copy link

coderabbitai bot commented Feb 14, 2025

Background

When using keyboard shortcuts (CTRL + U/I) to navigate to the top/bottom of the page, the log event number is not updated. This is because setPosition only allows specifying a source but not a reason for the cursor change event, resulting in NotSet reason.

Current Behavior

  • Keyboard shortcuts CTRL + U/I navigate to top/bottom of page
  • Log event number in URL doesn't update
  • Cursor change event has NotSet reason when using setPosition

Proposed Solution

Modify setupCursorExplicitPosChangeCallback to check for NotSet reason in addition to Explicit reason, as setPosition is currently the only way to trigger a cursor change event with NotSet reason.

References

@junhaoliao
Copy link
Member

This is a duplicate of #105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant