junhao review

Author: davemarco

src/components/StatusBar/LogLevelSelect/index.tsx

@@ -1,6 +1,8 @@
 import React, {
     useCallback,
     useContext,
+    useEffect,
+    useState,
 } from "react";
 
 import {SelectValue} from "@mui/base/useSelect";
@@ -30,7 +32,10 @@ import {
     LOG_LEVEL_NAMES,
     MAX_LOG_LEVEL,
 } from "../../../typings/logs";
-import {UI_ELEMENT} from "../../../typings/states";
+import {
+    UI_STATE,
+    UI_ELEMENT,
+} from "../../../typings/states";
 import {range} from "../../../utils/data";
 import {
     ignorePointerIfFastLoading,
@@ -149,7 +154,8 @@ const ClearFiltersOption = ({onClick}: ClearFiltersOptionProps) => {
  * @return
  */
 const LogLevelSelect = () => {
-    const {uiState, filterLogs, selectedLogLevels, setSelectedLogLevels} = useContext(StateContext);
+    const {uiState, filterLogs} = useContext(StateContext);
+    const [selectedLogLevels, setSelectedLogLevels] = useState<LOG_LEVEL[]>([]);
     const disabled = isDisabled(uiState, UI_ELEMENT.LOG_LEVEL_FILTER);
 
     const handleRenderValue = (selected: SelectValue<SelectOption<LOG_LEVEL>, true>) => (
@@ -215,6 +221,13 @@ const LogLevelSelect = () => {
         updateFilter([]);
     };
 
+    // On `uiState` update, clear `selectedLogLevels` if the state is `UI_STATE.FILE_LOADING`
+    useEffect(() => {
+        if (UI_STATE.FILE_LOADING === uiState) {
+            setSelectedLogLevels([]);
+        }
+    }, [uiState]);
+
     return (
         <Select
             className={`log-level-select ${ignorePointerIfFastLoading(uiState)}`}

src/contexts/StateContextProvider.tsx

@@ -73,7 +73,6 @@ interface StateContextType {
     numPages: number,
     onDiskFileSizeInBytes: number,
     pageNum: number,
-    selectedLogLevels: LOG_LEVEL[],
     queryProgress: number,
     queryResults: QueryResults,
 
@@ -82,7 +81,6 @@ interface StateContextType {
     loadFile: (fileSrc: FileSrcType, cursor: CursorType) => void,
     loadPageByAction: (navAction: NavigationAction) => void,
     setIsSettingsModalOpen: (isOpen: boolean) => void,
-    setSelectedLogLevels: (levels: LOG_LEVEL[]) => void,
     startQuery: (queryString: string, isRegex: boolean, isCaseSensitive: boolean) => void,
 }
 const StateContext = createContext<StateContextType>({} as StateContextType);
@@ -102,15 +100,13 @@ const STATE_DEFAULT: Readonly<StateContextType> = Object.freeze({
     pageNum: 0,
     queryProgress: QUERY_PROGRESS_INIT,
     queryResults: new Map(),
-    selectedLogLevels: [],
     uiState: UI_STATE.UNOPENED,
 
     exportLogs: () => null,
     filterLogs: () => null,
     loadFile: () => null,
     loadPageByAction: () => null,
     setIsSettingsModalOpen: () => null,
-    setSelectedLogLevels: () => null,
     startQuery: () => null,
 });
 
@@ -263,8 +259,6 @@ const StateContextProvider = ({children}: StateContextProviderProps) => {
     const [pageNum, setPageNum] = useState<number>(STATE_DEFAULT.pageNum);
     const [queryProgress, setQueryProgress] = useState<number>(STATE_DEFAULT.queryProgress);
     const [queryResults, setQueryResults] = useState<QueryResults>(STATE_DEFAULT.queryResults);
-    const [selectedLogLevels, setSelectedLogLevels] =
-        useState<LOG_LEVEL[]>(STATE_DEFAULT.selectedLogLevels);
     const [uiState, setUiState] = useState<UI_STATE>(STATE_DEFAULT.uiState);
 
     // Refs
@@ -413,7 +407,6 @@ const StateContextProvider = ({children}: StateContextProviderProps) => {
         setLogData("Loading...");
         setOnDiskFileSizeInBytes(STATE_DEFAULT.onDiskFileSizeInBytes);
         setExportProgress(STATE_DEFAULT.exportProgress);
-        setSelectedLogLevels(STATE_DEFAULT.selectedLogLevels);
 
         if ("string" !== typeof fileSrc) {
             updateWindowUrlSearchParams({[SEARCH_PARAM_NAMES.FILE_PATH]: null});
@@ -553,15 +546,13 @@ const StateContextProvider = ({children}: StateContextProviderProps) => {
                 pageNum: pageNum,
                 queryProgress: queryProgress,
                 queryResults: queryResults,
-                selectedLogLevels: selectedLogLevels,
                 uiState: uiState,
 
                 exportLogs: exportLogs,
                 filterLogs: filterLogs,
                 loadFile: loadFile,
                 loadPageByAction: loadPageByAction,
                 setIsSettingsModalOpen: setIsSettingsModalOpen,
-                setSelectedLogLevels: setSelectedLogLevels,
                 startQuery: startQuery,
             }}
         >