Skip to content

Commit 98bad59

Browse files
committed
junhao review
1 parent 53491e7 commit 98bad59

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

src/components/CentralContainer/Sidebar/SidebarTabs/index.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import SettingsOutlinedIcon from "@mui/icons-material/SettingsOutlined";
1616

1717
import {StateContext} from "../../../../contexts/StateContextProvider";
1818
import {TAB_NAME} from "../../../../typings/tab";
19+
import {openInNewTab} from "../../../../utils/url";
1920
import SettingsModal from "../../../modals/SettingsModal";
2021
import FileInfoTabPanel from "./FileInfoTabPanel";
2122
import SearchTabPanel from "./SearchTabPanel";
@@ -67,7 +68,7 @@ const SidebarTabs = forwardRef<HTMLDivElement, SidebarTabsProps>((
6768
setIsSettingsModalOpen(true);
6869
break;
6970
case TAB_NAME.DOCUMENTATION:
70-
window.open(DOCUMENTATION_URL, "_blank", "noopener");
71+
openInNewTab(DOCUMENTATION_URL);
7172
break;
7273
default:
7374
onActiveTabNameChange(tabName);

src/utils/url.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,17 @@ const getBasenameFromUrlOrDefault = (
4444
return basename;
4545
};
4646

47+
/**
48+
* Opens a given URL in a new browser tab.
49+
*
50+
* @param url
51+
*/
52+
const openInNewTab = (url: string): void => {
53+
window.open(url, "_blank", "noopener");
54+
};
4755

4856
export {
4957
getAbsoluteUrl,
5058
getBasenameFromUrlOrDefault,
59+
openInNewTab,
5160
};

0 commit comments

Comments
 (0)