Skip to content

Commit 0ba5cff

Browse files
authored
new-log-viewer: Treat ESLint warnings as errors; Remove ataylorme/eslint-annotate-action and instead rely on setup-node's problem matcher to annotate ESLint errors in PRs. (#71)
1 parent 2f653eb commit 0ba5cff

File tree

2 files changed

+2
-15
lines changed

2 files changed

+2
-15
lines changed

.github/workflows/lint.yaml

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,6 @@ concurrency:
2121
jobs:
2222
lint-check:
2323
runs-on: "ubuntu-latest"
24-
permissions:
25-
# So `eslint-annotate-action` can create / update status checks
26-
checks: "write"
27-
# So `eslint-annotate-action` can get pull request files
28-
contents: "read"
2924
steps:
3025
- uses: "actions/checkout@v4"
3126
with:
@@ -34,11 +29,4 @@ jobs:
3429
with:
3530
node-version: 22
3631
- run: "npm --prefix new-log-viewer/ clean-install"
37-
- run: "npm --prefix new-log-viewer/ run lint:ci"
38-
continue-on-error: true
39-
- uses: "ataylorme/eslint-annotate-action@v3"
40-
with:
41-
fail-on-error: true
42-
fail-on-warning: true
43-
only-pr-files: true
44-
report-json: "./new-log-viewer/eslint-report.json"
32+
- run: "npm --prefix new-log-viewer/ run lint:check"

new-log-viewer/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@
66
"scripts": {
77
"build": "webpack --config webpack.prod.js",
88
"lint": "npm run lint:check",
9-
"lint:ci": "npm run lint:check -- --output-file eslint-report.json --format json",
10-
"lint:check": "eslint src webpack.*.js",
9+
"lint:check": "eslint src webpack.*.js --max-warnings 0",
1110
"lint:fix": "npm run lint:check -- --fix",
1211
"start": "webpack serve --open --config webpack.dev.js"
1312
},

0 commit comments

Comments
 (0)