XWIKI-23610: Allow xwiki build to publish npm artifacts

Author: manuelleduc

pom.xml

@@ -126,7 +126,7 @@
     <oracle.version>21.20.0.0</oracle.version>
 
     <!-- npm registries configuration -->
-    <xwiki.npm.snapshot.registry>https://npm.snapshot.xwiki.org</xwiki.npm.snapshot.registry>
+    <xwiki.npm.snapshot.registry>https://nexus-snapshots.xwiki.org/repository/npmhosted/</xwiki.npm.snapshot.registry>
     <xwiki.npm.release.registry>https://registry.npmjs.org</xwiki.npm.release.registry>
   </properties>
   <scm>

xwiki-platform-core/xwiki-platform-node/pom.xml

@@ -124,7 +124,7 @@
               <goal>pnpm</goal>
             </goals>
             <configuration>
-              <arguments>run deploy</arguments>
+              <arguments>run deploy -- ${xwiki.npm.snapshot.registry} ${xwiki.npm.release.registry} ${basedir}/src/main/node</arguments>
               <workingDirectory>${basedir}/src/main/node</workingDirectory>
               <installDirectory>${basedir}/target</installDirectory>
               <environmentVariables>
@@ -135,6 +135,13 @@
           </execution>
         </executions>
       </plugin>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-deploy-plugin</artifactId>
+        <configuration>
+          <skip>true</skip>
+        </configuration>
+      </plugin>
     </plugins>
   </build>
 </project>

xwiki-platform-core/xwiki-platform-node/src/main/node/package.json

@@ -4,7 +4,7 @@
   "type": "module",
   "scripts": {
     "build": "nx run-many -t build -p \"xwiki-platform-core/xwiki-platform-node/src/main/node/*/**\"",
-    "deploy": "node scripts/deploy.js $NPM_SNAPSHOT_REGISTRY $NPM_RELEASE_REGISTRY",
+    "deploy": "node scripts/deploy.js",
     "lint": "nx run-many -t lint -p \"xwiki-platform-core/xwiki-platform-node/src/main/node/*/**\"",
     "test:unit": "nx run-many -t test -p \"xwiki-platform-core/xwiki-platform-node/src/main/node/*/**\""
   },

xwiki-platform-core/xwiki-platform-node/src/main/node/scripts/deploy.js

@@ -1,8 +1,8 @@
 #!/usr/bin/env node
 
-const fs = require('fs');
-const { execSync } = require('child_process');
-const path = require('path');
+import fs from 'fs';
+import {execSync} from 'child_process';
+import path from 'path';
 
 /**
  * Script to conditionally publish npm packages based on version type (SNAPSHOT vs release)
@@ -51,19 +51,11 @@ function findPackageJsonFiles(dir, fileList = []) {
 /**
  * Update version in a package.json file
  * @param {string} packageJsonPath - Path to package.json
+ * @param {Object} packageJson - Parsed package.json content
  * @param {string} timestamp - Timestamp to replace SNAPSHOT with
  * @returns {Object} - {success, originalVersion, newVersion, packageName, isSnapshot}
  */
-function updatePackageVersion(packageJsonPath, timestamp) {
-  let packageJson;
-
-  try {
-    packageJson = JSON.parse(fs.readFileSync(packageJsonPath, 'utf8'));
-  } catch (error) {
-    console.error(`Error reading ${packageJsonPath}: ${error.message}`);
-    return { success: false };
-  }
-
+function updatePackageVersion(packageJsonPath, packageJson, timestamp) {
   const originalVersion = packageJson.version;
   const packageName = packageJson.name;
   const isSnapshot = originalVersion.includes('SNAPSHOT');
@@ -110,24 +102,40 @@ if (packageJsonFiles.length === 0) {
 }
 
 // Generate a common timestamp for all packages.
-const timestamp = Math.floor(Date.now() / 1000);
+const timestamp = Math.floor(Date.now() / 1000).toString();
 
 // Determine if we're dealing with SNAPSHOT or release versions
 // Check the first package.json to determine the mode
 let isSnapshotMode = false;
 try {
-  const firstPackage = JSON.parse(fs.readFileSync(packageJsonFiles[0], 'utf8'));
-  isSnapshotMode = firstPackage.version.includes('SNAPSHOT');
+  // Look for the first package.json file with a version.
+  const firstVersion = packageJsonFiles.map(packageJsonPath => JSON.parse(fs.readFileSync(packageJsonPath, 'utf8')))
+    .filter(packageJson => packageJson.version)
+    .map(packageJson => packageJson.version)[0];
+  isSnapshotMode = firstVersion.includes('SNAPSHOT');
 } catch (error) {
   console.error('Error determining version mode');
   process.exit(1);
 }
 
-
 // Step 1: Update all package.json versions
-const updates = packageJsonFiles.map(packageJsonPath => {
-  const result = updatePackageVersion(packageJsonPath, timestamp.toString());
-  return { ...result, path: packageJsonPath };
+const updates = packageJsonFiles
+  .map(packageJsonPath => {
+    let packageJson;
+
+    try {
+      packageJson = JSON.parse(fs.readFileSync(packageJsonPath, 'utf8'));
+    } catch (error) {
+      console.error(`Error reading ${packageJsonPath}: ${error.message}`);
+      return {success: false};
+    }
+
+    return {packageJsonPath, packageJson, success: true}
+  })
+  .filter(({packageJsonPath, packageJson, success}) => success && packageJson.version)
+  .map(({packageJsonPath, packageJson}) => {
+  const result = updatePackageVersion(packageJsonPath, packageJson, timestamp);
+  return {...result, path: packageJsonPath};
 });
 
 const failedUpdates = updates.filter(u => !u.success);
@@ -137,8 +145,6 @@ if (failedUpdates.length > 0) {
   process.exit(1);
 }
 
-
-
 try {
   if (isSnapshotMode) {
     execSync(