Skip to content

Upgrade to target ES6 #2748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tyriar opened this issue Mar 2, 2020 · 5 comments
Closed

Upgrade to target ES6 #2748

Tyriar opened this issue Mar 2, 2020 · 5 comments
Labels
type/debt Technical debt that could slow us down in the long run

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 2, 2020

VS Code just dropped IE11 support so it could target ES6. I suggest we do the same which makes Old Edge v18 the low bar: microsoft/vscode#90676

This would mean cutting IE11 support completely which could cause problems for some clients so we'll target v5 as this will make IE11 incompatible with the lib.

@Tyriar Tyriar added the type/debt Technical debt that could slow us down in the long run label Mar 2, 2020
@Tyriar Tyriar added this to the 5.0.0 milestone Mar 2, 2020
@Tyriar Tyriar mentioned this issue Mar 28, 2020
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Mar 28, 2020
@TomzBench
Copy link

TomzBench commented Mar 8, 2021

@Tyriar Is there a workaround to import xterm as an es6 module?

This works ok for building. But my dev environment does not do any bundling. Tools like snowpack, webdevserver and etc serve es6 module directly. But this module cannot import into this environment.

@TomzBench
Copy link

@Tyriar

I added a tsconfig.es6.json overlay that builds the codebase as an es6 module and bundles with rollup. It doesn't touch the codebase and only adds extra tsconfig build files. So it's like a parallel build setup... If interested i can submit a PR and we can figure out way to publish it adjacent to the regular build.

https://github.com/TomzBench/xterm.js

@jogibear9988
Copy link

@Tyriar @TomzBench
I've exactly the same problem. I don't do any bundling, so I cannot use this in browser. ES& import does not work, but also loading via script tag does not, cause it checks for existence of "define" and this is here cause of monaco editor.

You could also add an additional es6 build to the package.json

@jogibear9988
Copy link

@Tyriar
Copy link
Member Author

Tyriar commented Nov 19, 2021

duplicate of #2878

@Tyriar Tyriar closed this as completed Nov 19, 2021
@Tyriar Tyriar removed this from the 5.0.0 milestone Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/debt Technical debt that could slow us down in the long run
Projects
None yet
Development

No branches or pull requests

3 participants