-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Upgrade to target ES6 #2748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@Tyriar Is there a workaround to import xterm as an es6 module? This works ok for building. But my dev environment does not do any bundling. Tools like snowpack, webdevserver and etc serve es6 module directly. But this module cannot import into this environment. |
I added a tsconfig.es6.json overlay that builds the codebase as an es6 module and bundles with rollup. It doesn't touch the codebase and only adds extra tsconfig build files. So it's like a parallel build setup... If interested i can submit a PR and we can figure out way to publish it adjacent to the regular build. |
@Tyriar @TomzBench You could also add an additional es6 build to the package.json |
duplicate of #2878 |
VS Code just dropped IE11 support so it could target ES6. I suggest we do the same which makes Old Edge v18 the low bar: microsoft/vscode#90676
This would mean cutting IE11 support completely which could cause problems for some clients so we'll target v5 as this will make IE11 incompatible with the lib.
The text was updated successfully, but these errors were encountered: