Skip to content

Commit 7612f2d

Browse files
committed
fix: fix Image is imported from both Rive and Flutter.
Signed-off-by: Sahil Kumar <[email protected]>
1 parent 35a8172 commit 7612f2d

File tree

6 files changed

+19
-11
lines changed

6 files changed

+19
-11
lines changed

CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## Upcoming
2+
3+
- Fix `Image` is imported from both packages. [#110](https://github.com/xsahil03x/giffy_dialog/issues/110)
4+
15
## 2.1.0
26

37
- Bump rive version to ^0.13.0.

example/lib/main.dart

+8-4
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,13 @@ import 'package:flutter/material.dart';
22
import 'package:giffy_dialog/giffy_dialog.dart';
33
import 'package:google_fonts/google_fonts.dart';
44

5-
void main() => runApp(new MyApp());
5+
void main() => runApp(MyApp());
66

77
final material3Notifier = ValueNotifier<bool>(true);
88

99
class MyApp extends StatelessWidget {
10+
const MyApp({super.key});
11+
1012
@override
1113
Widget build(BuildContext context) {
1214
return ValueListenableBuilder<bool>(
@@ -35,6 +37,8 @@ class MyApp extends StatelessWidget {
3537
}
3638

3739
class MyHomePage extends StatelessWidget {
40+
const MyHomePage({super.key});
41+
3842
@override
3943
Widget build(BuildContext context) {
4044
return Scaffold(
@@ -67,7 +71,7 @@ class MyHomePage extends StatelessWidget {
6771
}
6872

6973
class MaterialToggleButtons extends StatelessWidget {
70-
const MaterialToggleButtons({Key? key}) : super(key: key);
74+
const MaterialToggleButtons({super.key});
7175

7276
@override
7377
Widget build(BuildContext context) {
@@ -87,7 +91,6 @@ class MaterialToggleButtons extends StatelessWidget {
8791

8892
return ToggleButtons(
8993
isSelected: [!useMaterial3, useMaterial3],
90-
children: [Text('Material 2'), Text('Material 3')],
9194
borderRadius: borderRadius,
9295
borderColor: borderColor,
9396
selectedBorderColor: borderColor,
@@ -101,6 +104,7 @@ class MaterialToggleButtons extends StatelessWidget {
101104
onPressed: (index) {
102105
material3Notifier.value = index == 1;
103106
},
107+
children: [Text('Material 2'), Text('Material 3')],
104108
);
105109
}
106110
}
@@ -216,7 +220,7 @@ class TypedExample extends StatelessWidget {
216220
);
217221
}
218222

219-
return Container(
223+
return SizedBox(
220224
height: 36,
221225
child: Row(
222226
children: [

example/pubspec.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@ publish_to: 'none'
55
version: 1.0.0+1
66

77
environment:
8-
sdk: ">=3.2.0 <4.0.0"
8+
sdk: ^3.2.0
99
flutter: ">=3.16.0"
1010

1111
dependencies:
1212
flutter:
1313
sdk: flutter
1414
giffy_dialog:
1515
path: ../
16-
google_fonts: ^4.0.3
16+
google_fonts: ^6.2.0
1717

1818
flutter:
1919
uses-material-design: true

lib/giffy_dialog.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
library giffy_dialog;
1+
library;
22

33
export 'package:lottie/lottie.dart';
44
export 'package:rive/rive.dart';

lib/src/giffy_modal.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import 'dart:ui';
22

33
import 'package:flutter/material.dart';
44
import 'package:lottie/lottie.dart';
5-
import 'package:rive/rive.dart';
5+
import 'package:rive/rive.dart' hide Image;
66

77
import 'entry_animation.dart';
88

pubspec.yaml

+3-3
Original file line numberDiff line numberDiff line change
@@ -6,19 +6,19 @@ repository: https://github.com/xsahil03x/giffy_dialog
66
issue_tracker: https://github.com/xsahil03x/giffy_dialog/issues
77

88
environment:
9-
sdk: ">=3.2.0 <4.0.0"
9+
sdk: ^3.2.0
1010
flutter: ">=3.16.0"
1111

1212
dependencies:
1313
flutter:
1414
sdk: flutter
1515
rive: ^0.13.0
16-
lottie: ^3.0.0
16+
lottie: ^3.1.0
1717

1818
dev_dependencies:
1919
flutter_test:
2020
sdk: flutter
21-
flutter_lints: ^3.0.0
21+
flutter_lints: ">=4.0.0 <6.0.0"
2222

2323
topics:
2424
- dialog

0 commit comments

Comments
 (0)