fix: strip trailing semicolon in cosmosdb and unify implementation

cosmosdb, like several other databases, needs trailing semicolons to be
removed from the statement before it is passed to the driver.

This fix applies that to cosmosdb and makes the other databases with identical
processing use the same implementation - presto, trino, athena, SAP ASE.

Drivers that strip trailing semicolon as part of other processing are
not included in the refactoring to keep scope small.

Testing: will run usql with trino, and cosmosdb

Author: murfffi

drivers/athena/athena.go

@@ -5,22 +5,15 @@ package athena
 
 import (
 	"context"
-	"regexp"
 
 	_ "github.com/uber/athenadriver/go" // DRIVER: awsathena
-	"github.com/xo/dburl"
 	"github.com/xo/usql/drivers"
 )
 
 func init() {
-	endRE := regexp.MustCompile(`;?\s*$`)
 	drivers.Register("awsathena", drivers.Driver{
 		AllowMultilineComments: true,
-		Process: func(_ *dburl.URL, prefix string, sqlstr string) (string, string, bool, error) {
-			sqlstr = endRE.ReplaceAllString(sqlstr, "")
-			typ, q := drivers.QueryExecType(prefix, sqlstr)
-			return typ, sqlstr, q, nil
-		},
+		Process:                drivers.StripTrailingSemicolon,
 		Version: func(ctx context.Context, db drivers.DB) (string, error) {
 			var ver string
 			err := db.QueryRowContext(

drivers/cosmos/cosmos.go

@@ -9,5 +9,7 @@ import (
 )
 
 func init() {
-	drivers.Register("cosmos", drivers.Driver{})
+	drivers.Register("cosmos", drivers.Driver{
+		Process: drivers.StripTrailingSemicolon,
+	}, "gocosmos")
 }

drivers/drivers.go

@@ -9,6 +9,7 @@ import (
 	"fmt"
 	"io"
 	"reflect"
+	"regexp"
 	"strings"
 	"time"
 	"unicode"
@@ -612,3 +613,11 @@ func CopyWithInsert(placeholder func(int) string) func(ctx context.Context, db *
 func init() {
 	dburl.OdbcIgnoreQueryPrefixes = []string{"usql_"}
 }
+
+var endRE = regexp.MustCompile(`;?\s*$`)
+
+func StripTrailingSemicolon(_ *dburl.URL, prefix string, sqlstr string) (string, string, bool, error) {
+	sqlstr = endRE.ReplaceAllString(sqlstr, "")
+	typ, q := QueryExecType(prefix, sqlstr)
+	return typ, sqlstr, q, nil
+}

drivers/presto/presto.go

@@ -5,22 +5,15 @@ package presto
 
 import (
 	"context"
-	"regexp"
 
 	_ "github.com/prestodb/presto-go-client/presto" // DRIVER
-	"github.com/xo/dburl"
 	"github.com/xo/usql/drivers"
 )
 
 func init() {
-	endRE := regexp.MustCompile(`;?\s*$`)
 	drivers.Register("presto", drivers.Driver{
 		AllowMultilineComments: true,
-		Process: func(_ *dburl.URL, prefix string, sqlstr string) (string, string, bool, error) {
-			sqlstr = endRE.ReplaceAllString(sqlstr, "")
-			typ, q := drivers.QueryExecType(prefix, sqlstr)
-			return typ, sqlstr, q, nil
-		},
+		Process:                drivers.StripTrailingSemicolon,
 		Version: func(ctx context.Context, db drivers.DB) (string, error) {
 			var ver string
 			err := db.QueryRowContext(

drivers/sapase/sapase.go

@@ -6,17 +6,14 @@ package sapase
 import (
 	"context"
 	"errors"
-	"regexp"
 	"strconv"
 	"strings"
 
 	"github.com/thda/tds" // DRIVER: tds
-	"github.com/xo/dburl"
 	"github.com/xo/usql/drivers"
 )
 
 func init() {
-	endRE := regexp.MustCompile(`;?\s*$`)
 	drivers.Register("tds", drivers.Driver{
 		AllowMultilineComments:  true,
 		RequirePreviousPassword: true,
@@ -49,10 +46,6 @@ func init() {
 		IsPasswordErr: func(err error) bool {
 			return strings.Contains(err.Error(), "Login failed")
 		},
-		Process: func(_ *dburl.URL, prefix string, sqlstr string) (string, string, bool, error) {
-			sqlstr = endRE.ReplaceAllString(sqlstr, "")
-			typ, q := drivers.QueryExecType(prefix, sqlstr)
-			return typ, sqlstr, q, nil
-		},
+		Process: drivers.StripTrailingSemicolon,
 	})
 }

drivers/trino/trino.go

@@ -6,17 +6,14 @@ package trino
 import (
 	"context"
 	"io"
-	"regexp"
 
 	_ "github.com/trinodb/trino-go-client/trino" // DRIVER
-	"github.com/xo/dburl"
 	"github.com/xo/usql/drivers"
 	"github.com/xo/usql/drivers/metadata"
 	infos "github.com/xo/usql/drivers/metadata/informationschema"
 )
 
 func init() {
-	endRE := regexp.MustCompile(`;?\s*$`)
 	newReader := func(db drivers.DB, opts ...metadata.ReaderOption) metadata.Reader {
 		ir := infos.New(
 			infos.WithPlaceholder(func(int) string { return "?" }),
@@ -40,11 +37,7 @@ func init() {
 	}
 	drivers.Register("trino", drivers.Driver{
 		AllowMultilineComments: true,
-		Process: func(_ *dburl.URL, prefix string, sqlstr string) (string, string, bool, error) {
-			sqlstr = endRE.ReplaceAllString(sqlstr, "")
-			typ, q := drivers.QueryExecType(prefix, sqlstr)
-			return typ, sqlstr, q, nil
-		},
+		Process:                drivers.StripTrailingSemicolon,
 		Version: func(ctx context.Context, db drivers.DB) (string, error) {
 			var ver string
 			err := db.QueryRowContext(