-
-
Notifications
You must be signed in to change notification settings - Fork 489
Auto-update stlab to v2.1.4 #8449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the process of keeping project dependencies up-to-date by integrating the latest version of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request automatically updates the stlab package to version v2.1.4. The change is functionally correct. However, it highlights an inconsistency in how package versions are sorted within this repository. This package now has versions sorted in descending order, while other packages like cmake use ascending order. For better long-term maintainability, I recommend standardizing on a single sorting convention, which may require updating the auto-update script.
|
|
||
| add_urls("https://github.com/stlab/libraries/archive/refs/tags/$(version).tar.gz", | ||
| "https://github.com/stlab/libraries.git") | ||
| add_versions("v2.1.4", "34f3b96fb4896e72de218967e41d9090a5fc24e868d125ba61e5ac9570e8964a") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this correctly adds the new version, it places it at the top, resulting in a descending sort order. Other packages in this repository (e.g., cmake) use an ascending sort order for versions. To improve consistency and maintainability across the repository, it would be best to enforce a single sorting convention. The current auto-update script behavior of prepending new versions seems to be the cause of this inconsistency when different files have different initial sorting.
New version of stlab detected (package version: v1.6.2, last github version: v2.1.4)