-
Notifications
You must be signed in to change notification settings - Fork 164
Add CMake build system #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yes, a PR would be appropriate. |
I'm really looking for CMake as well. |
Yes, me too. I'm looking for CMake. |
Is the idea behind adding cmake to remove an obsolete windows build system? I asked in https://gitlab.xiph.org/xiph/theora/-/issues/2316 and xiph/theora#14 for a rationale, but have not gotten any clear answer, so the patch is still pending. If cmake is a the best build system to provide for Windows, perhaps all the win32/ directories should be replaced with cmake build rules? |
@petterreinholdtsen Oh, wow, I thought this project was well and truly dead. I'm not sure about this because I'm not familiar with the library, and I don't want to spend ages figuring out how it works. Right now I'm figuring out how to just manually place all the types in speex_config_types.h.in because all I did was add the source files to my project, which worked on Windows, but now on Linux doesn't compile because speex_config_types.h doesn't exist. I'm just going define:
Myself and include the source files in my project. It saves having to do ./configure or using Mesa or Autotools or any of the many different tools. Having a CMake build system would be good, but I think I can hack my way around it by just changing a couple of things. |
@petterreinholdtsen Isn't it the case that usually a CMakeLists.txt is provided that the user adds, and any platform specific differences are handled within the CMakeLists.txt? I don't know about C (and I know this is a C library), but in C++ CMake is pretty much the defacto standard, for better or worse. |
So, if I understand this correctly, adding cmake as an extra build
system do not remove the need for build files in win32/. A cmake build
system would be a convenience for those that do not want to run
configure, and would be more familiar for those programming with C++. I
was hoping it could remove the need for another build system, like
meson, win32/ stuff and scons.
Every extra build system add extra work on the maintainer when she is
modifying the source or adding build options. This lead to my view that
adding more build systems require a clear and tangable advantage, but I
have yet to see such advanage described by those proposing to add a new
build system to the Xiph projects. Did I miss it?
…--
Happy hacking
Petter Reinholdtsen
|
@petterreinholdtsen "Every extra build system add extra work on the maintainer when she is |
Visual Studio projects are obsolete, VS2008 project is broken.
I have working CMakeLists.txt project for speex, with almost every Autotools option implemented. That means you can generate Unix makefiles, VS 6.0-2017 projects and many more.
If you are interested, i will make pull request or patch.
The text was updated successfully, but these errors were encountered: