Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favorite: if word in a folder of favorite, use star_blue.svg instead of star.svg #2167

Open
lengyijun opened this issue Feb 18, 2025 · 3 comments

Comments

@lengyijun
Copy link
Contributor

lengyijun commented Feb 18, 2025

If no group set

@lengyijun
Copy link
Contributor Author

If group set to all, a word should be marked as favorited is it's saved in any path

@shenlebantongying
Copy link
Collaborator

shenlebantongying commented Feb 18, 2025

It looks like the feature is already implemented?

if ( index == ui.tabWidget->currentIndex() ) {
// Set icon for "Add to Favorites" action
if ( isWordPresentedInFavorites( title, cfg.lastMainGroupId ) ) {
addToFavorites->setIcon( blueStarIcon );
addToFavorites->setToolTip( tr( "Remove current tab from Favorites" ) );
}
else {
addToFavorites->setIcon( starIcon );
addToFavorites->setToolTip( tr( "Add current tab to Favorites" ) );
}
updateWindowTitle();
}

Though, based on the implementation, it might not work on KDE/Linux due to this bug #1484

@xiaoyifang
Copy link
Owner

The logic for bookmarks is not very user-friendly. Currently, each group can be associated with different folder groups in the bookmarks. This leads to several issues. For example, if word A is in folder F1, the icon indicates that it is bookmarked. If the user navigate to folder F2 in the bookmarks panel, what icon should be used(bookmarked or not?) Should the user be allowed to add this word again to folder F2? When deleting word A, should it be removed from F1, or from both F1 and F2

lengyijun added a commit to lengyijun/goldendict-ng that referenced this issue Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants