Rewrite extension.js

- Handles snippet resolving in memory instead of through file system I/O
- Bumps `vscode` engine to 1.8.0
- Chnages configuration identifier and semicolon property
- Formats CHANGELOG.md
- Updates prettier config of trailing commas

Author: felicio

.gitignore

@@ -196,4 +196,3 @@ FakesAssemblies/
 *.opt
 
 *.vsix
-snippets/snippets.json

.prettierrc

@@ -1,5 +1,5 @@
 {
   "singleQuote": true,
-  "trailingComma": "es5",
+  "trailingComma": "none",
   "semi": true
 }

.vscode/launch.json

@@ -7,8 +7,7 @@
       "request": "launch",
       "runtimeExecutable": "${execPath}",
       "args": ["--extensionDevelopmentPath=${workspaceRoot}"],
-      "stopOnEntry": false,
-      "preLaunchTask": "clean"
+      "stopOnEntry": false
     }
   ]
 }

.vscode/tasks.json

@@ -1,4 +1,5 @@
 # Change Log
 
-This project adheres to [Semantic Versioning](http://semver.org/).  
-Every release, along with the migration instructions, is documented on the Github [Releases](https://github.com/xabikos/vscode-javascript/releases) page.
+This project adheres to [Semantic Versioning](http://semver.org/). Every
+release, along with the migration instructions, is documented on the Github
+[Releases](https://github.com/xabikos/vscode-javascript/releases) page.

CHANGELOG.md

@@ -11,7 +11,7 @@
     "url": "https://github.com/xabikos/vscode-javascript"
   },
   "engines": {
-    "vscode": "^1.3.0"
+    "vscode": "^1.8.0"
   },
   "main": "./src/extension",
   "activationEvents": [
@@ -29,43 +29,19 @@
     "configuration": {
       "title": "JavaScript Snippets",
       "properties": {
-        "javascript-snippets.semicolons": {
+        "snippets-javascript.semi": {
           "type": "boolean",
           "default": true,
-          "description": "Uses semicolons. Restart is requierd."
+          "description": "Uses semicolons"
         }
       }
-    },
-    "snippets": [
-      {
-        "language": "javascript",
-        "path": "./snippets/snippets.json"
-      },
-      {
-        "language": "typescript",
-        "path": "./snippets/snippets.json"
-      },
-      {
-        "language": "javascriptreact",
-        "path": "./snippets/snippets.json"
-      },
-      {
-        "language": "typescriptreact",
-        "path": "./snippets/snippets.json"
-      },
-      {
-        "language": "html",
-        "path": "./snippets/snippets.json"
-      }
-    ]
+    }
   },
   "scripts": {
-    "postinstall": "node ./node_modules/vscode/bin/install",
-    "clean": "rimraf ./snippets/snippets.json"
+    "postinstall": "node ./node_modules/vscode/bin/install"
   },
   "devDependencies": {
     "eslint": "^4.10.0",
-    "rimraf": "^2.6.2",
     "vscode": "^1.1.6"
   }
 }

package.json

@@ -1,73 +1,83 @@
 'use strict';
 
-const fs = require('fs');
-const path = require('path');
 const vscode = require('vscode');
 
-const snippets = require('./snippets');
+const resolveSnippets = require('./snippets');
 
-const EXTENSION_ID = 'xabikos.JavaScriptSnippets';
+const EXTENSION_ID = 'snippets-javascript';
+
+const languageSelector = [
+  'javascript', // language identifier
+  'typescript',
+  'javascriptreact',
+  'typescriptreact',
+  'html'
+];
+let registeredSnippetProvider = undefined;
+
+class SnippetItem extends vscode.CompletionItem {
+  constructor(snippet) {
+    super(snippet.prefix, vscode.CompletionItemKind.Snippet);
+
+    this.insertText = new vscode.SnippetString(snippet.body);
+    this.detail = snippet.description;
+  }
+}
+
+class SnippetProvider {
+  constructor(snippets) {
+    this.snippets = snippets;
+  }
+
+  provideCompletionItems() {
+    return Object.keys(this.snippets).map(
+      name => new SnippetItem(this.snippets[name])
+    );
+  }
+}
 
 /** Activates extension on an emitted event. Invoked only once. */
 exports.activate = context => {
-  let configuration = vscode.workspace.getConfiguration('javascript-snippets');
+  let configuration = vscode.workspace.getConfiguration(EXTENSION_ID);
+  const semi = configuration.get('semi');
 
-  try {
-    writeSnippets(snippets(configuration.get('semicolons')));
-  } catch (error) {
-    console.error(`[${EXTENSION_ID}] ${error}`);
-    throw error; // terminates activation and shows a warning message
-  }
+  registeredSnippetProvider = registerSnippetProvider(semi);
 
-  const subscription = vscode.workspace.onDidChangeConfiguration(() => {
-    const previousConfiguration = configuration;
-    configuration = listener(previousConfiguration);
-  });
+  const changedConfigurationListener = vscode.workspace.onDidChangeConfiguration(
+    () => {
+      const previousConfiguration = configuration;
+      configuration = handleChangedConfiguration(previousConfiguration);
+    }
+  );
 
-  context.subscriptions.push(subscription);
+  context.subscriptions.push(
+    registeredSnippetProvider,
+    changedConfigurationListener
+  );
 };
 
-/** Listens for changes in extension configuration and return effective user's settings. */
-function listener(previousConfiguration) {
-  const configuration = vscode.workspace.getConfiguration(
-    'javascript-snippets'
-  );
-  const hasSemicolons = configuration.get('semicolons');
-
-  if (hasSemicolons !== previousConfiguration.get('semicolons')) {
-    try {
-      writeSnippets(snippets(hasSemicolons));
-      promptToReloadWindow();
-    } catch (error) {
-      vscode.window.showErrorMessage(
-        `Extension \`${EXTENSION_ID}\` failed to write snippets to the file.`
-      );
-      console.error(error);
-    }
+function handleChangedConfiguration(previousConfiguration) {
+  const configuration = vscode.workspace.getConfiguration(EXTENSION_ID);
+  const semi = configuration.get('semi');
+
+  if (previousConfiguration.get('semi') !== semi) {
+    registeredSnippetProvider = registerSnippetProvider(semi);
   }
 
   return configuration;
 }
 
-/** Synchronously writes snippets in JSON format to the file. */
-function writeSnippets(snippets) {
-  const snippetsPath = path.resolve(__dirname, '../snippets/snippets.json');
+function registerSnippetProvider(semi) {
+  if (registeredSnippetProvider) {
+    registeredSnippetProvider.dispose();
+  }
 
-  fs.writeFileSync(snippetsPath, JSON.stringify(snippets));
-}
+  const snippets = resolveSnippets(semi);
+  const provider = vscode.languages.registerCompletionItemProvider(
+    languageSelector,
+    new SnippetProvider(snippets),
+    '*'
+  );
 
-/** Prompts user to reload editor window in order for configuration change to take effect. */
-function promptToReloadWindow() {
-  const action = 'Reload';
-
-  vscode.window
-    .showInformationMessage(
-      `Reload window in order for change in extension \`${EXTENSION_ID}\` configuration to take effect.`,
-      action
-    )
-    .then(selectedAction => {
-      if (selectedAction === action) {
-        vscode.commands.executeCommand('workbench.action.reloadWindow');
-      }
-    });
+  return provider;
 }