-
Notifications
You must be signed in to change notification settings - Fork 72
Add ProofreadPage quality support and cover all Model #551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
agoujot
wants to merge
66
commits into
x-tools:main
Choose a base branch
from
agoujot:ecprpchanges
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #551 +/- ##
=============================================
+ Coverage 71.30% 85.69% +14.39%
- Complexity 1275 1330 +55
=============================================
Files 46 45 -1
Lines 3792 3937 +145
=============================================
+ Hits 2704 3374 +670
+ Misses 1088 563 -525 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
agoujot
added a commit
that referenced
this pull request
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In common
(Sorry if I use WS jargon, feel free to ask.)
EditCounter
PagesCreated
page_propswithpp_propname = "proofread_page_quality_level"TopEdits
getTopEditsAllNamespaces. Change from a 3-level query with custom row numbering with assignments and a random join at the end for the title (?) to a 2-level query with the built-inROW_NUMBER(the one that caused trouble when it reserved the name recently).page_propslike in PCDon't make a chart, though, because it implies being done over all the data and we can't do that for TopEdits (I think?). At any rate, right now all we do is count 'em; whereas for PC we already make some other stats.
Tests
I'm also adding many, many tests. 100% on all of Model! (That has led me to refactorise some code and fix a few bugs here and there.)
Bug: T173012