fixed #782: NPE in hover info when declaration was not found

Author: peq

de.peeeq.wurstscript/src/main/java/de/peeeq/wurstio/languageserver/requests/HoverInfo.java

@@ -121,6 +121,9 @@ private static String nearestScopeName(Element n) {
         }
 
         public List<Either<String, MarkedString>> description(NameDef n) {
+            if (n == null) {
+                return Collections.emptyList();
+            }
             List<Either<String, MarkedString>> result = new ArrayList<>();
             String comment = n.attrComment();
             if (comment != null && !comment.isEmpty()) {

de.peeeq.wurstscript/src/test/java/tests/wurstscript/tests/GetDefinitionTests.java

@@ -60,6 +60,17 @@ public void superConstructorCall() {
         testGetDef(testData, "3:4-3:13");
     }
 
+    @Test
+    public void nonexistantModule() {
+        CompletionTestData testData = input(
+                "package test",
+                "class A",
+                "	use B|lub"
+        );
+
+        testGetDef(testData, Collections.emptyList());
+    }
+
 
     private void testGetDef(CompletionTestData testData, String... expectedPositions) {
         testGetDef(testData, Arrays.asList(expectedPositions));

de.peeeq.wurstscript/src/test/java/tests/wurstscript/tests/HoverTests.java

@@ -0,0 +1,73 @@
+package tests.wurstscript.tests;
+
+import de.peeeq.wurstio.languageserver.BufferManager;
+import de.peeeq.wurstio.languageserver.ModelManager;
+import de.peeeq.wurstio.languageserver.ModelManagerImpl;
+import de.peeeq.wurstio.languageserver.WFile;
+import de.peeeq.wurstio.languageserver.requests.HoverInfo;
+import org.eclipse.lsp4j.*;
+import org.testng.annotations.Test;
+
+import java.io.File;
+import java.util.Collections;
+import java.util.List;
+import java.util.stream.Collectors;
+
+import static org.testng.Assert.assertEquals;
+
+/**
+ * tests the get definition functionality.
+ * <p>
+ * the position of the cursor is denoted by a bar "|" in the test cases
+ */
+public class HoverTests extends WurstLanguageServerTest {
+
+
+    @Test
+    public void nonexistantModule() {
+        CompletionTestData testData = input(
+                "package test",
+                "class A",
+                "	use B|lub"
+        );
+
+        List<String> text = testHoverText(testData);
+        assertEquals(Collections.emptyList(), text);
+    }
+
+
+    private List<String> testHoverText(CompletionTestData testData) {
+        Hover result = getHoverInfo(testData);
+        if (result.getContents().isLeft()) {
+            return result.getContents().getLeft()
+                    .stream()
+                    .map(s -> {
+                        if (s.isLeft()) {
+                            return s.getLeft();
+                        } else {
+                            return s.getRight().getValue();
+                        }
+                    })
+                    .collect(Collectors.toList());
+        } else {
+            MarkupContent right = result.getContents().getRight();
+            return Collections.singletonList(right.getValue());
+        }
+    }
+
+    private Hover getHoverInfo(CompletionTestData testData) {
+        BufferManager bufferManager = new BufferManager();
+        File projectPath = new File("./test-output").getAbsoluteFile();
+        ModelManager modelManager = new ModelManagerImpl(projectPath, bufferManager);
+        String uri = projectPath.toURI().toString() + "/wurst/test.wurst";
+        bufferManager.updateFile(WFile.create(uri), testData.buffer);
+        TextDocumentIdentifier textDocument = new TextDocumentIdentifier(uri);
+        Position pos = new Position(testData.line, testData.column);
+        CompletionParams position = new CompletionParams(textDocument, pos);
+        HoverInfo hoverInfo = new HoverInfo(position, bufferManager);
+
+        return hoverInfo.execute(modelManager);
+    }
+
+
+}