Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper envvars for DB credentials in D7 version #50

Open
tormi opened this issue Nov 2, 2023 · 2 comments
Open

Use proper envvars for DB credentials in D7 version #50

tormi opened this issue Nov 2, 2023 · 2 comments

Comments

@tormi
Copy link
Member

tormi commented Nov 2, 2023

https://github.com/wunderio/drupal-ping/blob/7.x/_ping.php#L301-L311 is using envvars with suffix _DRUPAL:

    // Echo "$DB_HOST_DRUPAL-$DB_NAME_DRUPAL-$DB_PASS_DRUPAL-$DB_PORT_DRUPAL-$DB_USER_DRUPAL"
    // | md5sum.
    if (!empty(getenv('DB_NAME_DRUPAL'))) {
      $host = getenv('DB_HOST_DRUPAL');
      $name = getenv('DB_NAME_DRUPAL');
      $pass = getenv('DB_PASS_DRUPAL');
      $port = getenv('DB_PORT_DRUPAL');
      $user = getenv('DB_USER_DRUPAL');
      $code = md5("$host-$name-$pass-$port-$user");
      return $code;
    }

Should we use DB_ envvars defined here instead: https://github.com/wunderio/charts/blob/master/drupal/files/settings.silta.d7.php ?

@tormi
Copy link
Member Author

tormi commented Nov 2, 2023

Also, there's no DB_PORT_DRUPAL or DB_PORT defined.

@tormi
Copy link
Member Author

tormi commented Nov 2, 2023

Also, there's no DB_PORT_DRUPAL or DB_PORT defined.

DB_PORT just arrived: wunderio/charts#396 ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant