Pydantic forms test findings

[florisie]

Do we want the select to look like this?
Maybe it should be a radio button group or a drop down field?

By the way, we have to select two ports here. One destination port for port one and one destination port for port 2.

I think it will be better to keep these selection separate. E.g. to be able to specifically choose the destination port for port 1 and the destination port for port 2. This also enables us to have a deterministic order of the ports in de AGGSP.

By the way, maybe the deterministic order is not necessary?? In that case we can leave it as is. Let's discuss it later...

Note Ruben 18-8: I can't reproduce the situation as shown in the image. I'll postpone fixing this until Wouter is back.
Tested with url: http://localhost:3001/workflows/new/modify_sn8_aggregated_service_port_move?subscriptionId=e841150d-67ee-4572-83e6-aa2fa97552c9 on gitlab-7 backend

[florisie]

FIXED: Removed port on the IP BGP modify form has a "date-test-id" instead of "data-testid":

[florisie]

On the IP Peer create form we previoulsy had drop downs with two values. Now we have elements where we can enter any value (although validation keeps us from submitting the wrong value). But I guess a drop down with only the allowed options would be better here.

Note Ruben 19-8: This relates to create peer port http://localhost:3001/workflows/new/create_ip_peer_port
The rendering of this field is changed purposely in this ticket: https://git.ia.surfsara.nl/netdev/automation/projects/orchestrator/-/issues/2376. Changing it to a dropdown could be done in the backend aswell.

[florisie]

This is the first page of the modify IP BGP form. We should be able to submit the pages without any validation errors (when not changing any settings). However, this form cannot be submitted without adding (and deleting) an entry for added ports. Also we have to first toggle the remove ports checkbox twice.

In other words, we can submit the forms without added ports and without selecting a port to remove. But we cannot submit the initial values for these fields. Therefore we need to first add/delete, toggle/twice.

Note Ruben 19-8: Fixed (in review)
http://localhost:3001/workflows/new/modify_sn8_ip_bgp?subscriptionId=d10b463c-f3fe-4c41-9082-92bbf91bec6f

[florisie]

On the Move SN8 service port form I can select a node. Subsequently it will show me the ports to choose from. But when I select the same node again then suddenly the node does no have any ports:

Ruben 20-8-25: Fixed in Review
http://localhost:3001/workflows/new/modify_sn8_service_port_move?subscriptionId=a6b68534-3a23-4dc6-81cc-38f39770b56d

[florisie]

On the first page of a form we see a cancel button. But once we submit the page then the button changes to a previous button (even if we didn't go to the next page due to validation errors):

Note Ruben 19-8: This is sort of by design. It works as Reset button here so you can go back to the previous values you've entered. Discuss?

[florisie]

On the second page of "create IP LIR prefix" we should be able to select a subnet size and then select from a list of free subnets. However there is not drop down to select from. This makes it very hard to determine the free subnet because no list with free subnets is shown:

Note Ruben 19-8: I think this is a feature request. The current situation is that the prefix is prefilled from the Lir prefixes page and preselecting is beign reintroduced in #2064

[florisie]

This is the modify L2VPN form. We should be able to delete this firewall endpoint but we cannot disable the radio button:

Note Ruben 19-8: http://localhost:3001/workflows/new/modify_sn8_l2vpn?subscriptionId=8f318a9c-eb3f-4b71-a88d-2fe6a8e04959
Fixed by removing the radio button component completely and making the select component Clearable so values can be unselected. Maybe there's a use case for a radiobutton somewhere so I have left the component in the lib

[florisie]

This is the create L3VPN form. There is a selected firewall indicated but we also need to feel in something into a textbox.

The form cannot be submitted without entering anything in the textbox.

I think we should be seeing a dropdown here with L3-firewall endpoints to choose from?

Note Ruben 19-8:
http://localhost:3001/workflows/new/create_sn8_l3vpn?productId=d73c6384-bd25-4178-891d-4b96953a9339
If there are no options - so the options array is [] - the field reverts to a text field. It should show a dropdown with no options I guess?

[florisie]

This used to be a drop down in the previous version. Now I have no idea what to enter here:

Note Ruben 19-8: This is the same problem as above where it defaults to a text field unless at least on option is provided