Skip to content

Deprecate workflow_target in ProcessSubscriptionTable and store_process_subscription() #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

kvklink
Copy link
Member

@kvklink kvklink commented Jul 4, 2025

Closes #974

Workflow target is fetched from the workflow table, and the equivalent column in the ProcessSubscription table is now deprecated.

It is now deprecated to call store_process_subscription() with a target parameter.

Copy link

codspeed-hq bot commented Jul 4, 2025

CodSpeed Performance Report

Merging #986 will not alter performance

Comparing 974-deprecare-process-target (a43d40d) with main (e888879)

Summary

✅ 12 untouched benchmarks

Copy link

codecov bot commented Jul 4, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.36%. Comparing base (e888879) to head (a43d40d).

Files with missing lines Patch % Lines
orchestrator/workflows/steps.py 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #986      +/-   ##
==========================================
- Coverage   84.39%   84.36%   -0.03%     
==========================================
  Files         213      213              
  Lines       10284    10287       +3     
  Branches     1010     1011       +1     
==========================================
  Hits         8679     8679              
- Misses       1337     1339       +2     
- Partials      268      269       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kvklink kvklink force-pushed the 974-deprecare-process-target branch from 3b47c77 to a43d40d Compare July 8, 2025 08:46
@Mark90 Mark90 changed the title Deprecate duplicate workflow_target column in ProcessSubscription table Deprecate workflow_target in ProcessSubscriptionTable and store_process_subscription() Jul 8, 2025
@Mark90 Mark90 merged commit 8d71842 into main Jul 8, 2025
14 of 16 checks passed
@Mark90 Mark90 deleted the 974-deprecare-process-target branch July 8, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maintenance]: Get process target from workflow definition, deprecate process_subscriptions.target
3 participants