Disallow deleting workflow processes through the API (#985)

Author: kvklink

orchestrator/api/api_v1/endpoints/processes.py

@@ -158,6 +158,9 @@ def delete(process_id: UUID) -> None:
     if not process:
         raise_status(HTTPStatus.NOT_FOUND)
 
+    if not process.is_task:
+        raise_status(HTTPStatus.BAD_REQUEST)
+
     db.session.delete(db.session.get(ProcessTable, process_id))
     db.session.commit()
 
@@ -270,7 +273,7 @@ def update_progress_on_awaiting_process_endpoint(
 @router.put(
     "/resume-all", response_model=ProcessResumeAllSchema, dependencies=[Depends(check_global_lock, use_cache=False)]
 )
-async def resume_all_processess_endpoint(request: Request, user: str = Depends(user_name)) -> dict[str, int]:
+async def resume_all_processes_endpoint(request: Request, user: str = Depends(user_name)) -> dict[str, int]:
     """Retry all task processes in status Failed, Waiting, API Unavailable or Inconsistent Data.
 
     The retry is started in the background, returning status 200 and number of processes in message.

test/unit_tests/api/test_processes.py

@@ -100,7 +100,20 @@ def test_show_not_found(test_client, started_process):
     assert HTTPStatus.NOT_FOUND == response.status_code
 
 
-def test_delete_process(responses, test_client, started_process):
+def test_delete_process_workflow(responses, test_client, started_process):
+    processes = test_client.get("/api/processes").json()
+    before_delete_count = len(processes)
+
+    response = test_client.delete(f"/api/processes/{started_process}")
+    assert HTTPStatus.BAD_REQUEST == response.status_code
+    assert before_delete_count == len(test_client.get("/api/processes").json())
+
+
+def test_delete_process_task(responses, test_client, started_process):
+    process = db.session.get(ProcessTable, started_process)
+    process.is_task = True
+    db.session.commit()
+
     processes = test_client.get("/api/processes").json()
     before_delete_count = len(processes)