Fix tests

Author: tjeerddie

oauth2_lib/fastapi.py

@@ -260,7 +260,7 @@ class GraphqlAuthorization(ABC):
     """
 
     @abstractmethod
-    async def authorize(self, request: RequestPath, user: OIDCUserModel) -> bool | None:
+    async def authorize(self, request: RequestPath, method: str, user: OIDCUserModel) -> bool | None:
         pass
 
 

tests/test_opa_graphql_decision.py

@@ -15,7 +15,7 @@
 async def test_opa_graphql_decision_auto_error():
     oauth2lib_settings.OAUTH2_ACTIVE = False
     authorization = GraphQLOPAAuthorization(opa_url="https://opa_url.test")
-    assert await authorization.authorize("", cast(OIDCUserModel, {})) is None
+    assert await authorization.authorize("", "QUERY", cast(OIDCUserModel, {})) is None
     oauth2lib_settings.OAUTH2_ACTIVE = True
 
 
@@ -28,13 +28,13 @@ async def test_opa_graphql_decision_user_not_allowed_autoerror_true(make_mock_as
     with patch("oauth2_lib.fastapi.AsyncClient", return_value=mock_async_client):
         authorization = GraphQLOPAAuthorization(opa_url="https://opa_url.test", auto_error=True)
         with pytest.raises(HTTPException) as exception_info:
-            await authorization.authorize("/test/path", user_info=user_info_matching)
+            await authorization.authorize("/test/path", "QUERY", user_info=user_info_matching)
 
         assert exception_info.value.status_code == HTTPStatus.FORBIDDEN
         expected_detail = f"User is not allowed to access resource: /test/path Decision was taken with id: {'8ef9daf0-1a23-4a6b-8433-c64ef028bee8'}"
         assert exception_info.value.detail == expected_detail
 
-        opa_input = {"input": {**user_info_matching, "resource": "/test/path", "method": "POST"}}
+        opa_input = {"input": {**user_info_matching, "resource": "/test/path", "method": "QUERY"}}
         mock_async_client.client.post.assert_called_with("https://opa_url.test", json=opa_input)
 
 
@@ -46,14 +46,14 @@ async def test_opa_graphql_decision_user_not_allowed_autoerror_false(make_mock_a
 
     with patch("oauth2_lib.fastapi.AsyncClient", return_value=mock_async_client):
         authorization = GraphQLOPAAuthorization(opa_url="https://opa_url.test", auto_error=False)
-        result = await authorization.authorize("/test/path", user_info_matching)
+        result = await authorization.authorize("/test/path", "QUERY", user_info_matching)
 
         assert result is False
         opa_input = {
             "input": {
                 **user_info_matching,
                 "resource": "/test/path",
-                "method": "POST",
+                "method": "QUERY",
             }
         }
         mock_async_client.client.post.assert_called_with("https://opa_url.test", json=opa_input)
@@ -67,14 +67,14 @@ async def test_opa_graphql_decision_user_allowed(make_mock_async_client):
 
     with patch("oauth2_lib.fastapi.AsyncClient", return_value=mock_async_client):
         authorization = GraphQLOPAAuthorization(opa_url="https://opa_url.test", auto_error=False)
-        result = await authorization.authorize("/test/path", user_info_matching)
+        result = await authorization.authorize("/test/path", "QUERY", user_info_matching)
 
         assert result is True
         opa_input = {
             "input": {
                 **user_info_matching,
                 "resource": "/test/path",
-                "method": "POST",
+                "method": "QUERY",
             }
         }
         mock_async_client.client.post.assert_called_with("https://opa_url.test", json=opa_input)
@@ -88,7 +88,7 @@ async def test_opa_graphql_decision_network_or_type_error(make_mock_async_client
         authorization = GraphQLOPAAuthorization(opa_url="https://opa_url.test")
 
         with pytest.raises(HTTPException) as exception:
-            await authorization.authorize("/test/path", user_info_matching)
+            await authorization.authorize("/test/path", "QUERY", user_info_matching)
 
         assert exception.value.status_code == 503
         assert exception.value.detail == "Policy agent is unavailable"
@@ -105,7 +105,7 @@ async def test_opa_graphql_decision_kwargs(make_mock_async_client):
             opa_url="https://opa_url.test", auto_error=False, opa_kwargs={"extra": 3}
         )
 
-        result = await authorization.authorize("/test/path", user_info_matching)
+        result = await authorization.authorize("/test/path", "QUERY", user_info_matching)
 
         assert result is True
 
@@ -114,7 +114,7 @@ async def test_opa_graphql_decision_kwargs(make_mock_async_client):
                 "extra": 3,
                 **user_info_matching,
                 "resource": "/test/path",
-                "method": "POST",
+                "method": "QUERY",
             }
         }
         mock_async_client.client.post.assert_called_with("https://opa_url.test", json=opa_input)
@@ -131,15 +131,15 @@ async def test_opa_decision_auto_error_not_allowed(make_mock_async_client):
             opa_url="https://opa_url.test", opa_kwargs={"extra": 3}, auto_error=False
         )
 
-        result = await authorization.authorize("/test/path", user_info_matching)
+        result = await authorization.authorize("/test/path", "QUERY", user_info_matching)
 
         assert result is False
         opa_input = {
             "input": {
                 "extra": 3,
                 **user_info_matching,
                 "resource": "/test/path",
-                "method": "POST",
+                "method": "QUERY",
             }
         }
         mock_async_client.client.post.assert_called_with("https://opa_url.test", json=opa_input)
@@ -156,15 +156,15 @@ async def test_opa_graphql_decision_auto_error_allowed(make_mock_async_client):
             opa_url="https://opa_url.test", opa_kwargs={"extra": 3}, auto_error=False
         )
 
-        result = await authorization.authorize("/test/path", user_info_matching)
+        result = await authorization.authorize("/test/path", "QUERY", user_info_matching)
 
         assert result is True
         opa_input = {
             "input": {
                 "extra": 3,
                 **user_info_matching,
                 "resource": "/test/path",
-                "method": "POST",
+                "method": "QUERY",
             }
         }
         mock_async_client.client.post.assert_called_with("https://opa_url.test", json=opa_input)