Add test for RemoteBlogSettings init with JSON

Author: mokagio

Sources/WordPressKit/Services/BlogServiceRemoteREST.h

@@ -66,4 +66,7 @@ typedef void (^SettingsHandler)(RemoteBlogSettings *settings);
                         success:(void(^)(NSDictionary *siteInfoDict))success
                         failure:(void (^)(NSError *error))failure;
 
+// FIXME: Temporary public for testing. Will remove once the logic moves to Swift
+- (RemoteBlogSettings *)remoteBlogSettingFromJSONDictionary:(NSDictionary *)json;
+
 @end

Tests/WordPressKitTests/Tests/RemoteBlogSettingsTests.swift

@@ -0,0 +1,30 @@
+@testable import WordPressKit
+import XCTest
+
+final class RemoteBlogSettingsTests: XCTestCase {
+
+    func testInitWithJSON() throws {
+        let jsonPath = try XCTUnwrap(
+            Bundle(for: type(of: self))
+                .path(forResource: "rest-site-settings", ofType: "json")
+        )
+        let json = try XCTUnwrap(JSONLoader().loadFile(jsonPath))
+        // FIXME: The init logic is currently in BlogServiceRemoteREST. We'll test it from there first, then update the test with the new location.
+        let blogService = BlogServiceRemoteREST(wordPressComRestApi: MockWordPressComRestApi(), siteID: 0)
+        let settings = try XCTUnwrap(blogService.remoteBlogSetting(fromJSONDictionary: json))
+
+        // Root properties
+        XCTAssertEqual(settings.name, "My Epic Blog")
+        XCTAssertEqual(settings.tagline, "Definitely, the best blog out there")
+        // Flattened settings properties
+        XCTAssertEqual(settings.privacy, 1)
+        XCTAssertEqual(settings.languageID, 31337)
+        XCTAssertNil(settings.iconMediaID)
+        XCTAssertEqual(settings.gmtOffset, 0)
+        // And so on...
+
+        // defaultPostFormat has custom decoding, so let's test it explicitly.
+        // Note that here we're obviously testing only one of the possible paths.
+        XCTAssertEqual(settings.defaultPostFormat, "standard")
+    }
+}

WordPressKit.xcodeproj/project.pbxproj

@@ -72,6 +72,7 @@
 		3FE2E94F2BB29A1B002CA2E1 /* FilePart.m in Sources */ = {isa = PBXBuildFile; fileRef = 3FE2E94D2BB29A1B002CA2E1 /* FilePart.m */; };
 		3FE2E9502BB29A1B002CA2E1 /* FilePart.h in Headers */ = {isa = PBXBuildFile; fileRef = 3FE2E94E2BB29A1B002CA2E1 /* FilePart.h */; settings = {ATTRIBUTES = (Public, ); }; };
 		3FE2E9672BBEB8D2002CA2E1 /* WordPressComRESTAPIVersion.h in Headers */ = {isa = PBXBuildFile; fileRef = 3FE2E9662BBEB8D2002CA2E1 /* WordPressComRESTAPIVersion.h */; settings = {ATTRIBUTES = (Public, ); }; };
+		3FE2E9692BBF7C10002CA2E1 /* RemoteBlogSettingsTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3FE2E9682BBF7C10002CA2E1 /* RemoteBlogSettingsTests.swift */; };
 		3FFCC0412BA995290051D229 /* Date+WordPressComTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3FFCC0402BA995290051D229 /* Date+WordPressComTests.swift */; };
 		3FFCC0472BAA6EF40051D229 /* NSDate+WordPressCom.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3FFCC0462BAA6EF40051D229 /* NSDate+WordPressCom.swift */; };
 		3FFCC0492BAB98130051D229 /* DateFormatter+WordPressCom.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3FFCC0482BAB98130051D229 /* DateFormatter+WordPressCom.swift */; };
@@ -817,6 +818,7 @@
 		3FE2E94D2BB29A1B002CA2E1 /* FilePart.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = FilePart.m; sourceTree = "<group>"; };
 		3FE2E94E2BB29A1B002CA2E1 /* FilePart.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = FilePart.h; sourceTree = "<group>"; };
 		3FE2E9662BBEB8D2002CA2E1 /* WordPressComRESTAPIVersion.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WordPressComRESTAPIVersion.h; sourceTree = "<group>"; };
+		3FE2E9682BBF7C10002CA2E1 /* RemoteBlogSettingsTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = RemoteBlogSettingsTests.swift; sourceTree = "<group>"; };
 		3FFCC0402BA995290051D229 /* Date+WordPressComTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "Date+WordPressComTests.swift"; sourceTree = "<group>"; };
 		3FFCC0462BAA6EF40051D229 /* NSDate+WordPressCom.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "NSDate+WordPressCom.swift"; sourceTree = "<group>"; };
 		3FFCC0482BAB98130051D229 /* DateFormatter+WordPressCom.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "DateFormatter+WordPressCom.swift"; sourceTree = "<group>"; };
@@ -1878,6 +1880,7 @@
 				FA1D0F8D299534FF0025D76C /* BlazeServiceRemoteTests.swift */,
 				465F88A6263B371D00F4C950 /* BlockEditorSettingsServiceRemoteTests.swift */,
 				74B5F0DD1EF82A9600B411E7 /* BlogServiceRemoteRESTTests.m */,
+				3FE2E9682BBF7C10002CA2E1 /* RemoteBlogSettingsTests.swift */,
 				FEE48EF52A4B3602008A48E0 /* BlogServiceRemote+ActiveFeaturesTests.swift */,
 				FEEFD8B6280EC91B00A3E261 /* BloggingPromptsServiceRemoteTests.swift */,
 				ABD95B7E25DD6C4B00735BEE /* CommentServiceRemoteRESTLikesTests.swift */,
@@ -3537,6 +3540,7 @@
 				FFA4D4AA2423B10A00BF5180 /* WordPressOrgRestApiTests.swift in Sources */,
 				74A44DD51F13C6D8006CD8F4 /* PushAuthenticationServiceRemoteTests.swift in Sources */,
 				4AE278482B2FBF1100E4D9B1 /* HTTPBodyEncodingTests.swift in Sources */,
+				3FE2E9692BBF7C10002CA2E1 /* RemoteBlogSettingsTests.swift in Sources */,
 				731BA83621DECD61000FDFCD /* SiteCreationRequestEncodingTests.swift in Sources */,
 				7EC60EBE22DC4F9000FB0336 /* EditorServiceRemoteTests.swift in Sources */,
 				931924241F1662FA0069CBCC /* JSONLoader.swift in Sources */,