You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#24216 extracts WPUserAgent to WordPressShared to enable sharing it with other modules. Whether or not modules should access it is debatable, but that's the state of the code we have at the moment and it's convenient to play along in the interest of laying the foundation to quickly prototype the dedicated Reader app.
Part of the work included adding CocoaLumberjack as a dependency in WordPressShared, but this resulted in some of the tests crashing because of compilation issues.
Given the whole idea of having a logging library in WordPressShared was debatable, #24216 (comment), and because of the focus in establishing support for Reader, I decided to simply remove the dependency via f95be44 instead of figuring out where the issue was.
This is a bread crumb to remind us to go back and find out.
#24216 extracts
WPUserAgent
to WordPressShared to enable sharing it with other modules. Whether or not modules should access it is debatable, but that's the state of the code we have at the moment and it's convenient to play along in the interest of laying the foundation to quickly prototype the dedicated Reader app.Part of the work included adding CocoaLumberjack as a dependency in WordPressShared, but this resulted in some of the tests crashing because of compilation issues.
Given the whole idea of having a logging library in WordPressShared was debatable, #24216 (comment), and because of the focus in establishing support for Reader, I decided to simply remove the dependency via f95be44 instead of figuring out where the issue was.
This is a bread crumb to remind us to go back and find out.
See also #24165
The text was updated successfully, but these errors were encountered: