Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider logging and error reporting for WordPressShared and UserAgent #24252

Open
mokagio opened this issue Mar 19, 2025 · 1 comment
Open

Comments

@mokagio
Copy link
Contributor

mokagio commented Mar 19, 2025

#24216 extracts WPUserAgent to WordPressShared to enable sharing it with other modules. Whether or not modules should access it is debatable, but that's the state of the code we have at the moment and it's convenient to play along in the interest of laying the foundation to quickly prototype the dedicated Reader app.

Part of the work included adding CocoaLumberjack as a dependency in WordPressShared, but this resulted in some of the tests crashing because of compilation issues.

Given the whole idea of having a logging library in WordPressShared was debatable, #24216 (comment), and because of the focus in establishing support for Reader, I decided to simply remove the dependency via f95be44 instead of figuring out where the issue was.

This is a bread crumb to remind us to go back and find out.


See also #24165

@dangermattic
Copy link
Collaborator

dangermattic commented Mar 19, 2025

Thanks for reporting! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants