Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralize accesses to CFBundleShortVersionString #24206

Open
mokagio opened this issue Mar 12, 2025 · 1 comment
Open

Centralize accesses to CFBundleShortVersionString #24206

mokagio opened this issue Mar 12, 2025 · 1 comment
Labels
Enhancement

Comments

@mokagio
Copy link
Contributor

mokagio commented Mar 12, 2025

While working on moving files for #24165, I noticed various pieces of code read CFBundleShortVersionString from the Bundle.

Most have their own function wrapping the access.

We might be better served improving upon the existing shortVersionString method in WordPressSharedObjC
@dangermattic
Copy link
Collaborator

dangermattic commented Mar 12, 2025 •
edited
Loading

Thanks for reporting! 👍

@jkmassel jkmassel added the Enhancement label Mar 17, 2025 — with Linear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jkmassel @mokagio @dangermattic