Remove ~= operation for BuildConfiguration

Author: kean

Modules/Sources/BuildSettingsKit/BuildConfiguration.swift

@@ -13,11 +13,11 @@ public enum BuildConfiguration: String, Sendable {
         BuildSettings.current.configuration
     }
 
-    public static func ~=(a: BuildConfiguration, b: Set<BuildConfiguration>) -> Bool {
-        return b.contains(a)
-    }
-
+    /// Returns `true` if the build is intented only for internal use.
     public var isInternal: Bool {
-        self ~= [.debug, .alpha]
+        switch self {
+        case .debug, .alpha: true
+        case .appStore: false
+        }
     }
 }

WordPress/Classes/Services/Page Layouts/PageLayoutService.swift

@@ -66,7 +66,7 @@ class PageLayoutService {
     }
 
     private static let supportedBlocks: String = {
-        let isDevMode = BuildConfiguration.current ~= [.debug, .alpha]
+        let isDevMode = BuildConfiguration.current.isInternal
         return Gutenberg.supportedBlocks(isDev: isDevMode).joined(separator: ",")
     }()
 
@@ -75,7 +75,7 @@ class PageLayoutService {
     private static let type = "mobile"
 
     // Return "true" or "false" for isBeta that gets passed into the endpoint.
-    private static let isBeta = String(BuildConfiguration.current ~= [.debug, .alpha])
+    private static let isBeta = String(BuildConfiguration.current.isInternal)
 
 }
 

WordPress/Classes/System/WordPressAppDelegate.swift

@@ -548,7 +548,7 @@ extension WordPressAppDelegate {
     /// Otherwise an anonymous remote will be used
     func updateFeatureFlags(authToken: String? = nil, completion: (() -> Void)? = nil) {
         // Enable certain feature flags on test builds.
-        if BuildConfiguration.current ~= [.alpha, .debug] {
+        if BuildConfiguration.current.isInternal {
             FeatureFlagOverrideStore().override(RemoteFeatureFlag.dotComWebLogin, withValue: true)
         }
 

WordPress/Classes/Utility/BuildInformation/FeatureFlag.swift

@@ -64,7 +64,7 @@ enum FeatureFlag: Int, CaseIterable {
         case .googleDomainsCard:
             return false
         case .voiceToContent:
-            return AppConfiguration.isJetpack && BuildConfiguration.current ~= [.debug, .alpha]
+            return AppConfiguration.isJetpack && BuildConfiguration.current.isInternal
         case .authenticateUsingApplicationPassword:
             return false
         case .newGutenberg:

WordPress/Classes/Utility/BuildInformation/RemoteFeatureFlag.swift

@@ -84,7 +84,7 @@ enum RemoteFeatureFlag: Int, CaseIterable {
         case .inAppUpdates:
             return false
         case .gravatarQuickEditor:
-            return BuildConfiguration.current ~= [.debug, .alpha]
+            return BuildConfiguration.current.isInternal
         case .dotComWebLogin:
             return false
         }

WordPress/Classes/ViewRelated/NUX/Helpers/WordPressAuthenticationManager.swift

@@ -60,7 +60,7 @@ extension WordPressAuthenticationManager {
     private func authenticatorConfiguation() -> WordPressAuthenticatorConfiguration {
         // SIWA can not be enabled for internal builds
         // Ref https://github.com/wordpress-mobile/WordPress-iOS/pull/12332#issuecomment-521994963
-        let enableSignInWithApple = !(BuildConfiguration.current ~= [.alpha])
+        let enableSignInWithApple = BuildConfiguration.current != .alpha
 
         return WordPressAuthenticatorConfiguration(
             wpcomClientId: ApiCredentials.client,