Skip to content

Remove cleanup from fromHtml #732

Open
@mzorz

Description

@mzorz

As part of #721 we needed to introduce a call to the cleaning procedure in the parser's fromHtml() here https://github.com/wordpress-mobile/AztecEditor-Android/blob/develop/aztec/src/main/java/org/wordpress/aztec/Html.java#L192 to make tests happy and because the AztecParser can be actually used as a standalone parser (as used in WPAndroid). In order to keep simmetry it seemed ok to leave the call to CleaningUtils.cleanNestedBoldTags(source); there. However, there was a superficial discussion about it not being strictly needed for most cases, while fromHtml is heavily used so it might incur in some performance penalty.

Opening a ticket here as discussed, to have this in mind as an optimisation in the future (to only make the call when / where needed).

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions