Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings Synchronization: Apple Pay / Google Pay #3985

Open
2 tasks
hsingyuc opened this issue Feb 26, 2025 · 2 comments
Open
2 tasks

Settings Synchronization: Apple Pay / Google Pay #3985

hsingyuc opened this issue Feb 26, 2025 · 2 comments
Assignees
Labels
status: blocked The issue is blocked from progressing, waiting for another piece of work to be done.

Comments

@hsingyuc
Copy link
Contributor

hsingyuc commented Feb 26, 2025

We aim to allow merchants to update gateway settings from both WC Stripe settings and Stripe dashboard settings.

In #3916 we are fetching the payment method configuration settings. For this issue, we want to hook up Apple Pay / Google Pay configuration settings to existing methods that check for Apple Pay / Google Pay enabled/disabled. After we are able to toggle settings from Stripe, and see those changes in the WooCommerce Stripe settings, we also want to be able to update the Stripe dashboard Apple Pay / Google Pay settings from the WC Stripe Apple Pay / Google Pay settings.

For example, this payment request response should be updated to use the Stripe configuration we added in #3916.

Image Image

Acceptance criteria

  • Merchants should be able to toggle settings from Stripe Apple Pay / Google Pay settings and we should see those changes in the WooCommerce Stripe Gateway Apple Pay / Google Pay settings.
  • Merchants should be able to toggle settings from WC stripe Apple Pay / Google Pay settings, and we should see those changes in the Stripe dashboard Apple Pay / Google Pay settings.

Notes

@hsingyuc hsingyuc added the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label Feb 26, 2025
@hsingyuc hsingyuc self-assigned this Mar 12, 2025
@annemirasol annemirasol self-assigned this Mar 20, 2025
@annemirasol
Copy link
Contributor

@hsingyuc In the Stripe dashboard, Apple Pay and Google Pay can be enabled/disabled separately, but in wp-admin, they are combined.

wp-admin Stripe dashboard
Image Image

I think we have 3 paths we can take:

  1. Separate Apple Pay and Google Pay in wp-admin.
  2. Keep them combined. At least one must be enabled in Stripe dashboard for the feature to be enabled in wp-admin.
  3. Keep them combined. Both must be enabled in Stripe dashboard for the feature to be enabled in wp-admin.

Option 1 is more intuitive for our merchants, although I'm worried about the work being bigger. With a view of what we are aiming to deliver for 9.4, would Option 2 or 3 be acceptable as a thin slice?

Also, do we know yet how we will do the migration?

@hsingyuc hsingyuc removed their assignment Mar 20, 2025
@hsingyuc
Copy link
Contributor Author

Option 1 is more intuitive for our merchants, although I'm worried about the work being bigger. With a view of what we are aiming to deliver for 9.4

With the delievery for 9.4, I agree we shouldn't expand the work right now. Perhaps adjust later if we need to.

would Option 2 or 3 be acceptable as a thin slice?

I think option 2 make sense and we can change to option 1 later if we want to.

Also, do we know yet how we will do the migration?

The idea is to get current admin settings, update Stripe dashboard settings, make sure we are getting a 200 response and delete the local options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: blocked The issue is blocked from progressing, waiting for another piece of work to be done.
Projects
None yet
Development

No branches or pull requests

2 participants