Fix checking empty span.

wo80 · wo80 · commit 2f3cfd3a594e · 2025-11-11T20:34:16.000+01:00
diff --git a/CSparse/Complex/Factorization/SparseCholesky.cs b/CSparse/Complex/Factorization/SparseCholesky.cs
@@ -120,9 +120,9 @@ public int NonZerosCount
         /// <param name="result">The left hand side vector, <c>x</c>.</param>
         public void Solve(ReadOnlySpan<Complex> input, Span<Complex> result)
         {
-            if (input == null) throw new ArgumentNullException(nameof(input));
+            if (input.IsEmpty) throw new ArgumentNullException(nameof(input));
 
-            if (result == null) throw new ArgumentNullException(nameof(result));
+            if (result.IsEmpty) throw new ArgumentNullException(nameof(result));
 
             var x = this.temp;
 
diff --git a/CSparse/Complex/Factorization/SparseLDL.cs b/CSparse/Complex/Factorization/SparseLDL.cs
@@ -126,9 +126,9 @@ public int NonZerosCount
         /// <param name="result">Solution vector x.</param>
         public void Solve(ReadOnlySpan<Complex> input, Span<Complex> result)
         {
-            if (input == null) throw new ArgumentNullException(nameof(input));
+            if (input.IsEmpty) throw new ArgumentNullException(nameof(input));
 
-            if (result == null) throw new ArgumentNullException(nameof(result));
+            if (result.IsEmpty) throw new ArgumentNullException(nameof(result));
 
             var x = temp;
 
diff --git a/CSparse/Complex/Factorization/SparseLU.cs b/CSparse/Complex/Factorization/SparseLU.cs
@@ -124,9 +124,9 @@ public int NonZerosCount
         /// <param name="result">The left hand side vector, <c>x</c>.</param>
         public void Solve(ReadOnlySpan<Complex> input, Span<Complex> result)
         {
-            if (input == null) throw new ArgumentNullException(nameof(input));
+            if (input.IsEmpty) throw new ArgumentNullException(nameof(input));
 
-            if (result == null) throw new ArgumentNullException(nameof(result));
+            if (result.IsEmpty) throw new ArgumentNullException(nameof(result));
 
             var x = this.temp;
 
diff --git a/CSparse/Complex/Factorization/SparseQR.cs b/CSparse/Complex/Factorization/SparseQR.cs
@@ -99,9 +99,9 @@ private SparseQR(int rows, int columns)
         /// </remarks>
         public override void Solve(ReadOnlySpan<Complex> input, Span<Complex> result)
         {
-            if (input == null) throw new ArgumentNullException(nameof(input));
+            if (input.IsEmpty) throw new ArgumentNullException(nameof(input));
 
-            if (result == null) throw new ArgumentNullException(nameof(result));
+            if (result.IsEmpty) throw new ArgumentNullException(nameof(result));
 
             var x = new Complex[S.m2];
 
@@ -154,9 +154,9 @@ public override void Solve(ReadOnlySpan<Complex> input, Span<Complex> result)
         /// <param name="result">The left hand side vector, <c>x</c>.</param>
         public void SolveTranspose(ReadOnlySpan<Complex> input, Span<Complex> result)
         {
-            if (input == null) throw new ArgumentNullException(nameof(input));
+            if (input.IsEmpty) throw new ArgumentNullException(nameof(input));
 
-            if (result == null) throw new ArgumentNullException(nameof(result));
+            if (result.IsEmpty) throw new ArgumentNullException(nameof(result));
 
             int m2 = S.m2;
 
diff --git a/CSparse/Double/Factorization/SparseCholesky.cs b/CSparse/Double/Factorization/SparseCholesky.cs
@@ -119,9 +119,9 @@ public int NonZerosCount
         /// <param name="result">The left hand side vector, <c>x</c>.</param>
         public void Solve(ReadOnlySpan<double> input, Span<double> result)
         {
-            if (input == null) throw new ArgumentNullException(nameof(input));
+            if (input.IsEmpty) throw new ArgumentNullException(nameof(input));
 
-            if (result == null) throw new ArgumentNullException(nameof(result));
+            if (result.IsEmpty) throw new ArgumentNullException(nameof(result));
 
             var x = this.temp;
 
diff --git a/CSparse/Double/Factorization/SparseLDL.cs b/CSparse/Double/Factorization/SparseLDL.cs
@@ -125,9 +125,9 @@ public int NonZerosCount
         /// <param name="result">Solution vector x.</param>
         public void Solve(ReadOnlySpan<double> input, Span<double> result)
         {
-            if (input == null) throw new ArgumentNullException(nameof(input));
+            if (input.IsEmpty) throw new ArgumentNullException(nameof(input));
 
-            if (result == null) throw new ArgumentNullException(nameof(result));
+            if (result.IsEmpty) throw new ArgumentNullException(nameof(result));
 
             var x = temp;
 
diff --git a/CSparse/Double/Factorization/SparseLU.cs b/CSparse/Double/Factorization/SparseLU.cs
@@ -123,9 +123,9 @@ public int NonZerosCount
         /// <param name="result">The left hand side vector, <c>x</c>.</param>
         public void Solve(ReadOnlySpan<double> input, Span<double> result)
         {
-            if (input == null) throw new ArgumentNullException(nameof(input));
+            if (input.IsEmpty) throw new ArgumentNullException(nameof(input));
 
-            if (result == null) throw new ArgumentNullException(nameof(result));
+            if (result.IsEmpty) throw new ArgumentNullException(nameof(result));
 
             var x = this.temp;
 
@@ -152,9 +152,9 @@ public void Solve(ReadOnlySpan<double> input, Span<double> result)
         /// <param name="result">The left hand side vector, <c>x</c>.</param>
         public void SolveTranspose(ReadOnlySpan<double> input, Span<double> result)
         {
-            if (input == null) throw new ArgumentNullException(nameof(input));
+            if (input.IsEmpty) throw new ArgumentNullException(nameof(input));
 
-            if (result == null) throw new ArgumentNullException(nameof(result));
+            if (result.IsEmpty) throw new ArgumentNullException(nameof(result));
 
             var x = this.temp;
 
diff --git a/CSparse/Double/Factorization/SparseQR.cs b/CSparse/Double/Factorization/SparseQR.cs
@@ -98,9 +98,9 @@ private SparseQR(int rows, int columns)
         /// </remarks>
         public override void Solve(ReadOnlySpan<double> input, Span<double> result)
         {
-            if (input == null) throw new ArgumentNullException(nameof(input));
+            if (input.IsEmpty) throw new ArgumentNullException(nameof(input));
 
-            if (result == null) throw new ArgumentNullException(nameof(result));
+            if (result.IsEmpty) throw new ArgumentNullException(nameof(result));
 
             var x = new double[S.m2];
 
@@ -152,9 +152,9 @@ public override void Solve(ReadOnlySpan<double> input, Span<double> result)
         /// <param name="result">The left hand side vector, <c>x</c>.</param>
         public void SolveTranspose(ReadOnlySpan<double> input, Span<double> result)
         {
-            if (input == null) throw new ArgumentNullException(nameof(input));
+            if (input.IsEmpty) throw new ArgumentNullException(nameof(input));
 
-            if (result == null) throw new ArgumentNullException(nameof(result));
+            if (result.IsEmpty) throw new ArgumentNullException(nameof(result));
 
             int m2 = S.m2;
 

Original file line number	Diff line number	Diff line change
`@@ -120,9 +120,9 @@ public int NonZerosCount`
`120`	`120`	`/// <param name="result">The left hand side vector, <c>x</c>.</param>`
`121`	`121`	`public void Solve(ReadOnlySpan<Complex> input, Span<Complex> result)`
`122`	`122`	`{`
`123`		`- if (input == null) throw new ArgumentNullException(nameof(input));`
	`123`	`+ if (input.IsEmpty) throw new ArgumentNullException(nameof(input));`
`124`	`124`
`125`		`- if (result == null) throw new ArgumentNullException(nameof(result));`
	`125`	`+ if (result.IsEmpty) throw new ArgumentNullException(nameof(result));`
`126`	`126`
`127`	`127`	`var x = this.temp;`
`128`	`128`
Original file line number	Diff line number	Diff line change
`@@ -126,9 +126,9 @@ public int NonZerosCount`
`126`	`126`	`/// <param name="result">Solution vector x.</param>`
`127`	`127`	`public void Solve(ReadOnlySpan<Complex> input, Span<Complex> result)`
`128`	`128`	`{`
`129`		`- if (input == null) throw new ArgumentNullException(nameof(input));`
	`129`	`+ if (input.IsEmpty) throw new ArgumentNullException(nameof(input));`
`130`	`130`
`131`		`- if (result == null) throw new ArgumentNullException(nameof(result));`
	`131`	`+ if (result.IsEmpty) throw new ArgumentNullException(nameof(result));`
`132`	`132`
`133`	`133`	`var x = temp;`
`134`	`134`
Original file line number	Diff line number	Diff line change
`@@ -124,9 +124,9 @@ public int NonZerosCount`
`124`	`124`	`/// <param name="result">The left hand side vector, <c>x</c>.</param>`
`125`	`125`	`public void Solve(ReadOnlySpan<Complex> input, Span<Complex> result)`
`126`	`126`	`{`
`127`		`- if (input == null) throw new ArgumentNullException(nameof(input));`
	`127`	`+ if (input.IsEmpty) throw new ArgumentNullException(nameof(input));`
`128`	`128`
`129`		`- if (result == null) throw new ArgumentNullException(nameof(result));`
	`129`	`+ if (result.IsEmpty) throw new ArgumentNullException(nameof(result));`
`130`	`130`
`131`	`131`	`var x = this.temp;`
`132`	`132`
Original file line number	Diff line number	Diff line change
`@@ -119,9 +119,9 @@ public int NonZerosCount`
`119`	`119`	`/// <param name="result">The left hand side vector, <c>x</c>.</param>`
`120`	`120`	`public void Solve(ReadOnlySpan<double> input, Span<double> result)`
`121`	`121`	`{`
`122`		`- if (input == null) throw new ArgumentNullException(nameof(input));`
	`122`	`+ if (input.IsEmpty) throw new ArgumentNullException(nameof(input));`
`123`	`123`
`124`		`- if (result == null) throw new ArgumentNullException(nameof(result));`
	`124`	`+ if (result.IsEmpty) throw new ArgumentNullException(nameof(result));`
`125`	`125`
`126`	`126`	`var x = this.temp;`
`127`	`127`
Original file line number	Diff line number	Diff line change
`@@ -125,9 +125,9 @@ public int NonZerosCount`
`125`	`125`	`/// <param name="result">Solution vector x.</param>`
`126`	`126`	`public void Solve(ReadOnlySpan<double> input, Span<double> result)`
`127`	`127`	`{`
`128`		`- if (input == null) throw new ArgumentNullException(nameof(input));`
	`128`	`+ if (input.IsEmpty) throw new ArgumentNullException(nameof(input));`
`129`	`129`
`130`		`- if (result == null) throw new ArgumentNullException(nameof(result));`
	`130`	`+ if (result.IsEmpty) throw new ArgumentNullException(nameof(result));`
`131`	`131`
`132`	`132`	`var x = temp;`
`133`	`133`