Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BMI var names inconsistent #20

Open
sverhoeven opened this issue Nov 7, 2019 · 2 comments
Open

BMI var names inconsistent #20

sverhoeven opened this issue Nov 7, 2019 · 2 comments
Assignees
@JaroCamphuijsen

Comments

@sverhoeven
Copy link
Collaborator

get_input_var_names and get_value use different names. And var flux_out contiains 2 vars, should be split into 2 vars Q and Ea
@sverhoeven sverhoeven self-assigned this Nov 7, 2019
JaroCamphuijsen added a commit that referenced this issue Nov 7, 2019
@JaroCamphuijsen
fixed names and types in get_value function, refs #19 #20
2a97c73
sverhoeven added a commit that referenced this issue Nov 13, 2019
@sverhoeven
Corrected most data types and var namings
819bdf7 
Refs #19 and #20
@sverhoeven
Copy link
Collaborator Author

Names of model are exposed in BMI functions.
Model variables which are structs have been flattened into multiple variables.

@sverhoeven
Copy link
Collaborator Author

@JaroCamphuijsen could you check if all variables have consistent names?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JaroCamphuijsen JaroCamphuijsen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sverhoeven @JaroCamphuijsen