[Android] Keyboard doesn't hide on unmount. Keyboard.dismiss doesn't work

[Reeywhaar]

Description

Keyboard does not hide on screen change on Android.
Keyboard.dismiss() on Android does nothing.

React Native version:

System:
    OS: macOS 11.2.2
    CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
    Memory: 956.86 MB / 32.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 15.7.0 - /usr/local/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 7.4.3 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.10.1 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 14.4, DriverKit 20.2, macOS 11.1, tvOS 14.3, watchOS 7.2
    Android SDK:
      API Levels: 28, 29, 30
      Build Tools: 28.0.3, 29.0.2, 30.0.2
      System Images: android-29 | Google Play Intel x86 Atom, android-30 | Google APIs Intel x86 Atom, android-30 | Google Play Intel x86 Atom
      Android NDK: Not Found
  IDEs:
    Android Studio: 4.1 AI-201.8743.12.41.7042882
    Xcode: 12.4/12D4e - /usr/bin/xcodebuild
  Languages:
    Java: 15.0.1 - /usr/bin/javac
    Python: 2.7.16 - /usr/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.13.1 => 16.13.1 
    react-native: 0.63.3 => 0.63.3 
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

react-native-navigation: 7.10.0, 7.11 (tried all patch versions)

Steps To Reproduce

1. Navigate to screen with TextInput
2. Tap on TextInput
3. Pop mounted screen
4. Keyboard does not hide by itself and calling Keyboard.dismiss() does nothing.

Expected Results

Keyboard should hide both automatically and by calling Keyboard.dismiss.

[Reeywhaar]

Noticed that bug occurs if root has layout with side menu.

[webforuse]

bug confirmed. It is played if there is a side menu

[Dein1]

Experiencing the same on android with side menu enabled.

[enahum]

This diff fixes it for us. We are using RNN 7.11.3, there is another bug we have with 7.16.0 about sharedElements not working correctly but this diff should give you an idea

diff --git a/node_modules/react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/viewcontroller/ViewController.java b/node_modules/react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/viewcontroller/ViewController.java
index 6b28fc7..8bb2a76 100644
--- a/node_modules/react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/viewcontroller/ViewController.java
+++ b/node_modules/react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/viewcontroller/ViewController.java
@@ -1,10 +1,12 @@
 package com.reactnativenavigation.viewcontrollers.viewcontroller;
 
 import android.app.Activity;
+import android.content.Context;
 import android.view.View;
 import android.view.ViewGroup;
 import android.view.ViewManager;
 import android.view.ViewTreeObserver;
+import android.view.inputmethod.InputMethodManager;
 
 import com.reactnativenavigation.options.Options;
 import com.reactnativenavigation.options.params.Bool;
@@ -275,6 +277,8 @@ public abstract class ViewController<T extends ViewGroup> implements ViewTreeObs
             ((Destroyable) view).destroy();
         }
         if (view != null) {
+            InputMethodManager imm = (InputMethodManager)activity.getSystemService(Context.INPUT_METHOD_SERVICE);
+            imm.hideSoftInputFromWindow(view.getWindowToken(), 0);
             view.getViewTreeObserver().removeOnGlobalLayoutListener(this);
             view.setOnHierarchyChangeListener(null);
             if (view.getParent() instanceof ViewGroup) {

[fiznool]

Thank you @enahum, this fixes the problem perfectly. I created a PR to see if this can be applied to the project, in the meantime patch-package can be used to apply this automatically.

[enahum]

great to hear @fiznool but for us this was causing another issue as we have an in-app notification which is an overlay and when it gets dismissed the keyboard also hides so we ended up going with a different patch

diff --git a/node_modules/react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/component/ComponentViewController.java b/node_modules/react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/component/ComponentViewController.java
index 51837db..14a5828 100644
--- a/node_modules/react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/component/ComponentViewController.java
+++ b/node_modules/react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/component/ComponentViewController.java
@@ -4,6 +4,7 @@ import android.app.Activity;
 import android.content.res.Configuration;
 import android.view.View;
 
+import com.reactnativenavigation.options.params.NullBool;
 import com.reactnativenavigation.viewcontrollers.viewcontroller.ScrollEventListener;
 import com.reactnativenavigation.options.Options;
 import com.reactnativenavigation.viewcontrollers.viewcontroller.Presenter;
@@ -148,7 +149,7 @@ public class ComponentViewController extends ChildController<ComponentLayout> {
 
     @Override
     public void destroy() {
-        final boolean blurOnUnmount = options != null && options.modal.blurOnUnmount.isTrue();
+        final boolean blurOnUnmount = options != null && (options.modal.blurOnUnmount.isTrue() || options.overlayOptions.interceptTouchOutside instanceof NullBool);
         if (blurOnUnmount) {
             blurActivityFocus();
         }

[swabbass]

Please refer to this comment.

Can you kindly, follow the guidelines and provide a minimal reproducible demo, so we can reproduce it, and fix it properly?