Do not configure duplicate jars in one library (bazelbuild#7587)

When building library definitions:
- remember already included jars
- when selecting path for identical jars prefer already used paths

Bug: n/a
Test: n/a (existing)
Change-Id: Ie6e0b59394ac71635bf1d55298ae10d996d6ee3d

AOSP: 1ad3ce17ddd5bbe2dea9b6e92cce9017c814f576

Co-authored-by: Googler <[email protected]>

Author: sellophane

querysync/java/com/google/idea/blaze/qsync/java/AddCompiledJavaDeps.java

@@ -18,6 +18,7 @@
 import static com.google.common.collect.ImmutableSet.toImmutableSet;
 
 import com.google.idea.blaze.common.Context;
+import com.google.idea.blaze.common.PrintOutput;
 import com.google.idea.blaze.qsync.artifacts.BuildArtifact;
 import com.google.idea.blaze.qsync.deps.ArtifactDirectories;
 import com.google.idea.blaze.qsync.deps.ArtifactDirectoryBuilder;
@@ -27,10 +28,12 @@
 import com.google.idea.blaze.qsync.deps.ProjectProtoUpdateOperation;
 import com.google.idea.blaze.qsync.deps.TargetBuildInfo;
 import com.google.idea.blaze.qsync.project.ProjectProto.JarDirectory;
+import java.util.Comparator;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.Map;
 import java.util.Set;
+import java.util.stream.Collectors;
 
 /** Adds compiled jars from dependencies to the project. */
 public class AddCompiledJavaDeps implements ProjectProtoUpdateOperation {
@@ -43,18 +46,32 @@ public AddCompiledJavaDeps(boolean enableBazelAdditionalLibraryRootsProvider) {
   @Override
   public void update(ProjectProtoUpdate update, ArtifactTracker.State artifactState, Context<?> context) {
     ArtifactDirectoryBuilder javaDepsDir = update.artifactDirectory(ArtifactDirectories.JAVADEPS);
+    Set<String> skipped = new HashSet<>();
+    Set<String> seen = new HashSet<>();
     Map<String, Set<String>> libNameToJars = new HashMap<>();
     for (TargetBuildInfo target : artifactState.targets()) {
       if (target.javaInfo().isPresent()) {
         JavaArtifactInfo javaInfo = target.javaInfo().get();
-        for (BuildArtifact jar : javaInfo.jars()) {
+        Set<String> locallySeen = new HashSet<>();
+        for (BuildArtifact jar :
+          javaInfo.jars().stream()
+            // Prefer already added artifactPaths.
+            .sorted(Comparator.comparing(it -> !seen.contains(it.artifactPath().toString())))
+            .toList()) {
+          if (locallySeen.contains(jar.digest())) {
+            skipped.add(jar.artifactPath().toString());
+            continue;
+          }
+          locallySeen.add(jar.digest());
+          seen.add(jar.artifactPath().toString());
           javaDepsDir.addIfNewer(jar.artifactPath(), jar, target.buildContext());
           libNameToJars
-            .computeIfAbsent(target.label().toString(), t -> new HashSet())
+            .computeIfAbsent(target.label().toString(), t -> new HashSet<>())
             .add(javaDepsDir.path().resolve(jar.artifactPath()).toString());
         }
       }
     }
+    context.output(PrintOutput.output("Skipped " + skipped.size() + " duplicate jars"));
     if (!enableBazelAdditionalLibraryRootsProvider) {
       updateProjectProtoUpdateAllJarsInOneLibrary(javaDepsDir, update);
     } else {