Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ViewTransitions Default Behaviour doesn't work on Firefox #13064

Closed
1 task done
alexgagnon opened this issue Jan 24, 2025 · 1 comment
Closed
1 task done

ViewTransitions Default Behaviour doesn't work on Firefox #13064

alexgagnon opened this issue Jan 24, 2025 · 1 comment

Comments

@alexgagnon
Copy link

Astro Info

Astro                    v5.1.9
Node                     v18.20.3
System                   Linux (x64)
Package Manager          npm
Output                   static
Adapter                  none
Integrations             none

If this issue only occurs in one browser, which browser is a problem?

Firefox

Describe the Bug

Hi, it seems when I use ClientRouter on FF without any additional markup, nothing happens. To get it to work the way it does in Chromium/WebKit I need to add something like <html ... transition:name='fade'>

What's the expected result?

One of:

  • it should behave the same as Chromium/Webkit
  • the docs are updated to indicate the change required to also support Firefox

Link to Minimal Reproducible Example

https://stackblitz.com/edit/withastro-astro-jgjbzn1q?file=src%2Fpages%2Fabout.astro,src%2Fpages%2Findex.astro,src%2Flayouts%2FLayout.astro&title=Astro%20Starter%20Kit:%20Basics

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Jan 24, 2025
@martrapp martrapp removed the needs triage Issue needs to be triaged label Jan 26, 2025
@martrapp
Copy link
Member

Hi @alexgagnon 👋🏼, thank you very much for pointing this out!

The first alternative you suggested could lead to unexpected changes for existing sites. Considering this and our hope that Firefox will add native view-transition support soon, I'd prefer to keep the current behavior unchanged.

I really like your second suggestion. It would be great if you could open a PR against the withastro/docs repository to document this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexgagnon @martrapp