refactor: improve checking if session is available

Author: winternet-studio

Common.php

@@ -197,13 +197,15 @@ public static function setBufferValue($key, $value, $expiration = false) {
 	 */
 	public static function getBufferValue($key) {
 		// Clean up the buffer once per session
-		$session = Yii::$app->session;
-		if (Yii::$app->request->isConsoleRequest || !$session || !$session->get('_jfw_cleaned_buffer')) {
+		if (Yii::$app->has('session')) {  //skip cleaning when no session available (most often means running in CLI)
+			$session = Yii::$app->session;
+			if (Yii::$app->request->isConsoleRequest || !$session || !$session->get('_jfw_cleaned_buffer')) {
 
-			\Yii::$app->db->createCommand("DELETE FROM `buffer` WHERE tmpd_date_expire IS NOT NULL AND tmpd_date_expire < UTC_TIMESTAMP()")->execute();
+				\Yii::$app->db->createCommand("DELETE FROM `buffer` WHERE tmpd_date_expire IS NOT NULL AND tmpd_date_expire < UTC_TIMESTAMP()")->execute();
 
-			if ($session) {
-				$session->set('_jfw_cleaned_buffer', true);
+				if ($session) {
+					$session->set('_jfw_cleaned_buffer', true);
+				}
 			}
 		}
 

UserException.php

@@ -278,15 +278,17 @@ function __construct($msg, $arrayInternalInfo = [], $options = []) {
 				$fileLog = 'All details registered in database with error code '. $this->errorCode .' (errorID '. $errorID .').';
 
 				// Delete expired errors once per session
-				$session = Yii::$app->session;
-				if ($session && !Yii::$app->request->isConsoleRequest && !Yii::$app->response->isSent) {  //will get message if run in CLI: "session_set_cookie_params(): Cannot change session cookie parameters when headers already sent"
-					try {
-						if (!$session->get('wsErrorsCleared')) {
-							$dbConn->createCommand("DELETE FROM `". $databaseTable ."` WHERE err_expire_days IS NOT NULL AND TO_DAYS(err_timestamp) + err_expire_days < TO_DAYS(NOW())")->execute();
-							$session->set('wsErrorsCleared', 1);
+				if (Yii::$app->has('session')) {
+					$session = Yii::$app->session;
+					if ($session && !Yii::$app->request->isConsoleRequest && !Yii::$app->response->isSent) {  //will get message if run in CLI: "session_set_cookie_params(): Cannot change session cookie parameters when headers already sent"
+						try {
+							if (!$session->get('wsErrorsCleared')) {
+								$dbConn->createCommand("DELETE FROM `". $databaseTable ."` WHERE err_expire_days IS NOT NULL AND TO_DAYS(err_timestamp) + err_expire_days < TO_DAYS(NOW())")->execute();
+								$session->set('wsErrorsCleared', 1);
+							}
+						} catch (\Exception $e) {
+							throw $e;
 						}
-					} catch (\Exception $e) {
-						throw $e;
 					}
 				}
 			} else {

generators/crud2/default/search.php

@@ -123,7 +123,7 @@ public function searchable() {
 	public function search($params) {
 		// Handle memorizing the last used search parameters
 		$shortModelName = \yii\helpers\StringHelper::basename(__CLASS__);
-		if (Yii::$app->session && !Yii::$app->request->isConsoleRequest) {
+		if (Yii::$app->has('session') && !Yii::$app->request->isConsoleRequest) {
 			Yii::$app->session->open();
 			if (empty($params[$shortModelName])) {
 				if (!empty($_SESSION['cache'][__CLASS__]['searchParams'])) {