Apply Winter Coding Standards

Rel: wintercms/winter#1188

Author: LukeTowers

Plugin.php

@@ -1,18 +1,19 @@
-<?php namespace Winter\Pages;
+<?php
 
-use Backend;
+namespace Winter\Pages;
+
+use Backend\Facades\Backend;
 use Backend\Models\UserRole;
 use Cms\Classes\Controller as CmsController;
 use Cms\Classes\Theme;
-use Config;
-use Event;
 use System\Classes\PluginBase;
 use Winter\Pages\Classes\Controller;
 use Winter\Pages\Classes\Page as StaticPage;
 use Winter\Pages\Classes\Router;
 use Winter\Pages\Classes\Snippet;
 use Winter\Pages\Classes\SnippetManager;
 use Winter\Pages\Controllers\Index;
+use Winter\Storm\Support\Facades\Event;
 
 class Plugin extends PluginBase
 {
@@ -37,7 +38,7 @@ public function registerComponents(): array
             \Winter\Pages\Components\ChildPages::class => 'childPages',
             \Winter\Pages\Components\StaticPage::class => 'staticPage',
             \Winter\Pages\Components\StaticMenu::class => 'staticMenu',
-            \Winter\Pages\Components\StaticBreadcrumbs::class => 'staticBreadcrumbs'
+            \Winter\Pages\Components\StaticBreadcrumbs::class => 'staticBreadcrumbs',
         ];
     }
 
@@ -58,7 +59,7 @@ public function registerPermissions(): array
                 'order' => 200,
                 'roles' => [UserRole::CODE_DEVELOPER, UserRole::CODE_PUBLISHER],
                 'label' => 'winter.pages::lang.page.manage_menus',
-                ],
+            ],
             'winter.pages.manage_content' => [
                 'tab'   => 'winter.pages::lang.page.tab',
                 'order' => 200,
@@ -99,28 +100,28 @@ public function registerNavigation(): array
                         'label'       => 'winter.pages::lang.page.menu_label',
                         'icon'        => 'icon-files-o',
                         'url'         => 'javascript:;',
-                        'attributes'  => ['data-menu-item'=>'pages'],
+                        'attributes'  => ['data-menu-item' => 'pages'],
                         'permissions' => ['winter.pages.manage_pages'],
                     ],
                     'menus' => [
                         'label'       => 'winter.pages::lang.menu.menu_label',
                         'icon'        => 'icon-sitemap',
                         'url'         => 'javascript:;',
-                        'attributes'  => ['data-menu-item'=>'menus'],
+                        'attributes'  => ['data-menu-item' => 'menus'],
                         'permissions' => ['winter.pages.manage_menus'],
                     ],
                     'content' => [
                         'label'       => 'winter.pages::lang.content.menu_label',
                         'icon'        => 'icon-file-text-o',
                         'url'         => 'javascript:;',
-                        'attributes'  => ['data-menu-item'=>'content'],
+                        'attributes'  => ['data-menu-item' => 'content'],
                         'permissions' => ['winter.pages.manage_content'],
                     ],
                     'snippets' => [
                         'label'       => 'winter.pages::lang.snippet.menu_label',
                         'icon'        => 'icon-newspaper-o',
                         'url'         => 'javascript:;',
-                        'attributes'  => ['data-menu-item'=>'snippets'],
+                        'attributes'  => ['data-menu-item' => 'snippets'],
                         'permissions' => ['winter.pages.access_snippets'],
                     ],
                 ],
@@ -146,8 +147,8 @@ public function registerMarkupTags(): array
     {
         return [
             'filters' => [
-                'staticPage' => ['Winter\Pages\Classes\Page', 'url']
-            ]
+                'staticPage' => ['Winter\Pages\Classes\Page', 'url'],
+            ],
         ];
     }
 
@@ -239,19 +240,19 @@ protected function extendBackendForms(): void
      */
     protected function extendCmsTemplates(): void
     {
-        Event::listen('cms.template.save', function($controller, $template, $type) {
+        Event::listen('cms.template.save', function ($controller, $template, $type) {
             Plugin::clearCache();
         });
 
-        Event::listen('cms.template.processSettingsBeforeSave', function($controller, $dataHolder) {
+        Event::listen('cms.template.processSettingsBeforeSave', function ($controller, $dataHolder) {
             $dataHolder->settings = Snippet::processTemplateSettingsArray($dataHolder->settings);
         });
 
-        Event::listen('cms.template.processSettingsAfterLoad', function($controller, $template) {
+        Event::listen('cms.template.processSettingsAfterLoad', function ($controller, $template) {
             Snippet::processTemplateSettings($template);
         });
 
-        Event::listen('cms.template.processTwigContent', function($template, $dataHolder) {
+        Event::listen('cms.template.processTwigContent', function ($template, $dataHolder) {
             if ($template instanceof \Cms\Classes\Layout) {
                 $dataHolder->content = Controller::instance()->parseSyntaxFields($dataHolder->content);
             }
@@ -263,7 +264,7 @@ protected function extendCmsTemplates(): void
      */
     protected function extendCmsRouter(): void
     {
-        Event::listen('cms.router.beforeRoute', function($url) {
+        Event::listen('cms.router.beforeRoute', function ($url) {
             return Controller::instance()->initCmsPage($url);
         });
     }
@@ -273,7 +274,7 @@ protected function extendCmsRouter(): void
      */
     protected function extendCmsRenderer(): void
     {
-        Event::listen('cms.page.beforeRenderPage', function($controller, $page) {
+        Event::listen('cms.page.beforeRenderPage', function ($controller, $page) {
             /*
              * Before twig renders
              */
@@ -290,11 +291,11 @@ protected function extendCmsRenderer(): void
             }
         });
 
-        Event::listen('cms.page.initComponents', function($controller, $page) {
+        Event::listen('cms.page.initComponents', function ($controller, $page) {
             Controller::instance()->initPageComponents($controller, $page);
         });
 
-        Event::listen('cms.block.render', function($blockName, $blockContents) {
+        Event::listen('cms.block.render', function ($blockName, $blockContents) {
             $page = CmsController::getController()->getPage();
 
             if (!isset($page->apiBag['staticPage'])) {
@@ -313,24 +314,24 @@ protected function extendCmsRenderer(): void
      */
     protected function registerMenuItemTypes(): void
     {
-        Event::listen('pages.menuitem.listTypes', function() {
+        Event::listen('pages.menuitem.listTypes', function () {
             return [
                 'static-page'      => 'winter.pages::lang.menuitem.static_page',
-                'all-static-pages' => 'winter.pages::lang.menuitem.all_static_pages'
+                'all-static-pages' => 'winter.pages::lang.menuitem.all_static_pages',
             ];
         });
 
-        Event::listen('pages.menuitem.getTypeInfo', function($type) {
+        Event::listen('pages.menuitem.getTypeInfo', function ($type) {
             if ($type == 'url') {
                 return [];
             }
 
-            if ($type == 'static-page'|| $type == 'all-static-pages') {
+            if ($type == 'static-page' || $type == 'all-static-pages') {
                 return StaticPage::getMenuTypeInfo($type);
             }
         });
 
-        Event::listen('pages.menuitem.resolveItem', function($type, $item, $url, $theme) {
+        Event::listen('pages.menuitem.resolveItem', function ($type, $item, $url, $theme) {
             if ($type == 'static-page' || $type == 'all-static-pages') {
                 return StaticPage::resolveMenuItem($item, $url, $theme);
             }

assets/js/page-preview.js

@@ -63,7 +63,7 @@
      * @param {Event} event
      */
     PagePreview.prototype.onDeviceClick = function (event) {
-        const $clicked = $(event.currentTarget)
+        public const $clicked = $(event.currentTarget)
 
         // Remove active class from other options
         this.$deviceSelector.find('a').removeClass('active')