Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle different-aspect game cover images #116

Open
aaronklaassen opened this issue Oct 30, 2018 · 2 comments
Open

Handle different-aspect game cover images #116

aaronklaassen opened this issue Oct 30, 2018 · 2 comments
Assignees
Labels

Comments

@aaronklaassen
Copy link
Member

Launcher only supports 4:3 game cover images, and if someone uploads something else to the Network, it gets squished in the menu. Fixing it here is a better solution than fixing it API side: winnitron/winnitron_network#86

@mrmwiebe
Copy link
Member

Cool. So basically it looks like you're thinkin the same as me here where it just crops the image to fit the current frame instead of squishing it right? I can look into that.

@mrmwiebe mrmwiebe self-assigned this Oct 31, 2018
@aaronklaassen
Copy link
Member Author

aaronklaassen commented Oct 31, 2018

@mrmwiebe Or shows the whole image, ideally. I was going to crop it API-side just so that it didn't get squished, but showing the full image as-is in the menu would be the real fix.

I'm hesitant to crop because the cover images often have titles/text in them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants