Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do MIT-licensed packages need EULA=(non-empty) ? #931

Closed
mralusw opened this issue Nov 9, 2023 · 3 comments
Closed

do MIT-licensed packages need EULA=(non-empty) ? #931

mralusw opened this issue Nov 9, 2023 · 3 comments

Comments

@mralusw
Copy link
Contributor

mralusw commented Nov 9, 2023

For example I see that https://github.com/wimpysworld/deb-get/blob/main/01-main/packages/mdview has an EULA (thus prompting for confirmation). But it's MIT-licensed, just like deb-get itself. I somehow doubt that among all the other packages (none of which has a non-empty EULA=, except for chrome), there are no other MIT's.

Copy link

github-actions bot commented Nov 9, 2023

Hello there 👋
Thanks for submitting your first issue to the deb-get project 🐛 We'll try and take a look at your issue soon ⏲

In the meantime you might want to join the Wimpys World Discord 🗣 where we have a large community of Linux 🐧 enthusiasts and passionate open source developers 🧑‍💻

You might also be interested in following Wimpys World Twitch 📡 channel where Wimpy streams let's code video, including this project, several times a week. A back catalog of past live stream and other Linux related content is available on Wimpys World YouTube 📺 channel.

@mralusw mralusw changed the title do MIT-licensed packages need a EULA= line? do MIT-licensed packages need EULA=(non-empty) ? Nov 9, 2023
@philclifford
Copy link
Member

IANAL, but no in general you're right - it is solely there to meet requirements of the likes of chrome.
If, however, the author of an app adds a link to their own license in their own PR then so-be-it. It may be MIT now but could change. One might discuss with them whether there is value in provoking an action by the end-user that purports to "accept" an MIT license. @mapitman might decide to remove that line if he felt there was no value in forcing users to answer an EULA prompt for mdview
It might also be an area where the CONTRIBUTING.md could be improved.

@mapitman
Copy link
Contributor

This is the second thing I kind of messed up on when submitting the pull request for my application. I'll submit a PR later to remove this.

mapitman added a commit to mapitman/deb-get that referenced this issue Nov 11, 2023
There's no need to accept the license as it's MIT and a no brainer.
I had added this because whatever I was using for reference had it. I
didn't realize it made the user accept it.

Addresses wimpysworld#931
philclifford pushed a commit that referenced this issue Nov 11, 2023
There's no need to accept the license as it's MIT and a no brainer.
I had added this because whatever I was using for reference had it. I
didn't realize it made the user accept it.

Addresses #931
philclifford pushed a commit to philclifford/deb-get that referenced this issue Nov 11, 2023
There's no need to accept the license as it's MIT and a no brainer.
I had added this because whatever I was using for reference had it. I
didn't realize it made the user accept it.

Addresses wimpysworld#931
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants