utils.coerce - warning are opt-in

Author: wimglenn

aocd/models.py

@@ -329,7 +329,7 @@ def answer_a(self, val: AnswerValue) -> None:
         to the server if necessary.
         """
         if not isinstance(val, str):
-            val = coerce(val)
+            val = coerce(val, warn=True)
         if getattr(self, "answer_a", None) == val:
             return
         self._submit(value=val, part="a")
@@ -362,7 +362,7 @@ def answer_b(self, val: AnswerValue) -> None:
         to the server if necessary.
         """
         if not isinstance(val, str):
-            val = coerce(val)
+            val = coerce(val, warn=True)
         if getattr(self, "answer_b", None) == val:
             return
         self._submit(value=val, part="b")
@@ -422,7 +422,7 @@ def _submit(self, value, part, reopen=True, quiet=False, precheck=True):
         if value in NON_ANSWER:
             raise AocdError(f"cowardly refusing to submit non-answer: {value!r}")
         if not isinstance(value, str):
-            value = coerce(value)
+            value = coerce(value, warn=True)
         part = str(part).replace("1", "a").replace("2", "b").lower()
         if part not in {"a", "b"}:
             raise AocdError('part must be "a" or "b"')

aocd/utils.py

@@ -272,7 +272,7 @@ def _get_soup(html):
     return bs4.BeautifulSoup(html, "html.parser")
 
 
-def coerce(val: t.Any, warn: bool = True) -> str:
+def coerce(val: t.Any, warn: bool = False) -> str:
     """
     Convert answer `val` into a string suitable for HTTP submission.
     Technically adventofcode.com will only accept strings as answers,

tests/test_utils.py

@@ -98,7 +98,7 @@ def test_atomic_write_file(aocd_data_dir):
     ],
 )
 def test_type_coercions(v_raw, v_expected, len_logs, caplog):
-    v_actual = coerce(v_raw)
+    v_actual = coerce(v_raw, warn=True)
     assert v_actual == v_expected, f"{type(v_raw)} {v_raw})"
     assert len(caplog.records) == len_logs