Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations generate / merge fail php8 #313

Open
grekpg opened this issue Jan 4, 2021 · 1 comment
Open

Translations generate / merge fail php8 #313

grekpg opened this issue Jan 4, 2021 · 1 comment

Comments

@grekpg
Copy link

grekpg commented Jan 4, 2021

Hi i found that my messages file is almost empty

file Bazinga\Bundle\JsTranslationBundle\Controller
in method getTranslationsAction

i see in loop foreach ($files as $filename) {
$translations[$locale][$currentDomain] = array();

this clear array , when i add

if(!isset($translations[$locale][$currentDomain]))
$translations[$locale][$currentDomain] = array(); 

this fix error,

or maybe this fragment make problem:

[$currentDomain] = Util::extractCatalogueInformationFromFilename($filename);

but how to fix it on production ?

@grekpg grekpg changed the title Translations merge fail php8 Translations generate / merge fail php8 Jan 4, 2021
@thislg
Copy link
Contributor

thislg commented Feb 5, 2021

This issue was fixed in #305 and the fix was released in https://github.com/willdurand/BazingaJsTranslationBundle/releases/tag/4.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants