Skip to content

Commit 4382fa3

Browse files
committed
Update Rakefile, remove test that doesn't need to be run
1 parent e5c16de commit 4382fa3

File tree

2 files changed

+3
-14
lines changed

2 files changed

+3
-14
lines changed

Rakefile

+3-6
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,9 @@ Bundler.require
22
Bundler::GemHelper.install_tasks
33

44
require 'opal/rspec/rake_task'
5-
require 'react/source'
5+
require_relative 'spec/rails_assets'
66

7-
Opal::RSpec::RakeTask.new(:default) do |server, task|
8-
# Need a Phantom polyfill, there is a docs and js path, order is not guaranteed, so just append both
9-
RailsAssetsEs5Shim.load_paths.each {|p| server.append_path p}
10-
RailsAssetsJquery.load_paths.each { |p| server.append_path p }
11-
server.append_path File.dirname(React::Source.bundled_path_for('react-with-addons.js'))
7+
Opal::RSpec::RakeTask.new(:default) do |_, task|
8+
task.default_path = 'spec/opal'
129
task.pattern = 'spec/opal/**/*_spec.rb'
1310
end

spec/opal/react_spec.rb

-8
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,6 @@ def render
154154
end
155155
end
156156

157-
158157
describe "render" do
159158
async "should render element to DOM" do
160159
div = `document.createElement("div")`
@@ -178,13 +177,6 @@ def render
178177
expect(component).to respond_to(method_name)
179178
end
180179
end
181-
182-
pending "should return nil to prevent abstraction leakage" do
183-
div = `document.createElement("div")`
184-
expect {
185-
React.render(React.create_element('span') { "lorem" }, div)
186-
}.to be_nil
187-
end
188180
end
189181

190182
describe "render_to_string" do

0 commit comments

Comments
 (0)